-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: ASV offset #18926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: ASV offset #18926
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18926 +/- ##
==========================================
+ Coverage 91.55% 91.57% +0.02%
==========================================
Files 150 150
Lines 48939 48939
==========================================
+ Hits 44805 44815 +10
+ Misses 4134 4124 -10
Continue to review full report at Codecov.
|
can you reduce the add_offset size a bit, so these are in-line to the others? |
cc @jbrockmendel as you would expect on these? |
I don't see anything obviously problematic, but hard to say much without something to compare against. And even with, you know my thoughts on asv reliability... |
@mroeschke did you push the smaller n? can you show an update? |
Currently on vacation, but I will be back on the weekend to update the PR |
931364c
to
e97e7c0
Compare
Reduced the samples for the addition benchmarks by a factor of 10. Additionally changed the current lint rule for asv to capture the files I already cleaned up.
|
thanks! |
Consolidated all the offsets to a list that was reused for all the benchmarks.
The
ApplyIndex
benchmark seemed to be benchmarking arithmetic, so I changed it to specifically use theapply_index()
method