Skip to content

CLN: ASV panel_methods #18907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mroeschke
Copy link
Member

Flake8'd, param'd, and this benchmark was timing out on my machine so I scaled down the size of the Panel but should be representative of larger Panels

asv dev -b ^panel_methods
· Discovering benchmarks
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[  0.00%] ·· Building for existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  0.00%] ·· Benchmarking existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[ 50.00%] ··· Running panel_methods.PanelMethods.time_pct_change                                                                          ok
[ 50.00%] ···· 
               ======= =======
                 axis         
               ------- -------
                items   1.54s 
                major   1.39s 
                minor   1.41s 
               ======= =======

[100.00%] ··· Running panel_methods.PanelMethods.time_shift                                                                               ok
[100.00%] ···· 
               ======= =======
                 axis         
               ------- -------
                items   397μs 
                major   385μs 
                minor   390μs 
               ======= =======

@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #18907 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18907      +/-   ##
==========================================
+ Coverage   91.65%   91.67%   +0.02%     
==========================================
  Files         154      154              
  Lines       51368    51368              
==========================================
+ Hits        47080    47092      +12     
+ Misses       4288     4276      -12
Flag Coverage Δ
#multiple 89.54% <ø> (+0.02%) ⬆️
#single 40.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316acbf...456f900. Read the comment docs.

@jorisvandenbossche jorisvandenbossche added the Benchmark Performance (ASV) benchmarks label Dec 22, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.23.0 milestone Dec 22, 2017
@jorisvandenbossche jorisvandenbossche merged commit 6164da2 into pandas-dev:master Dec 22, 2017
@jorisvandenbossche
Copy link
Member

Thanks!

@mroeschke mroeschke deleted the asv_clean_panel_methods branch December 22, 2017 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants