Make DatetimeIndex iterator pickleable by dill #18848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, dill (https://github.com/uqfoundation/dill) cannot pickle iterators over DatetimeIndex because they are generators. This simple change removes that limitation.
gfyoung
added
Compat
|
@rmihael : Thanks for the PR! The change is relatively harmless it seems, so I'm okay with merging. However, should get feedback from @jreback and @jorisvandenbossche to double check. |
gfyoung
approved these changes
Dec 19, 2017
|
yep looks fine. thanks. |
|
thanks! |
4 tasks
|
@rmihael do you know the reason / case that this was useful? |
|
Sorry for the silence. I used dill to run multiprocess optimizations using the backtrader framework. I can use cloudpickle with the same success, so there is no need to add extra complexity to the codebase. |
|
no problem, thanks for answering! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, dill (https://github.com/uqfoundation/dill) cannot pickle iterators over DatetimeIndex because they are generators. This simple change removes that limitation.
git diff upstream/master -u -- "*.py" | flake8 --diff