Skipif no lzma ne #18820
Skipif no lzma ne #18820
Conversation
| @@ -370,27 +361,25 @@ def to_series(mi, level): | |||
| raise AssertionError("object must be a Series or Index") | |||
|
|
|||
| def test_raise_on_panel_with_multiindex(self, parser, engine): | |||
| tm.skip_if_no_ne() | |||
There was a problem hiding this comment.
Minor bug before where this wasn't passing engine as an argument to the skip_if function, so this test was always being skipped on systems lacking numexpr, even for non-numexpr engines
| p = tm.makePanel(7) | ||
| p.items = tm.makeCustomIndex(len(p.items), nlevels=2) | ||
| with pytest.raises(NotImplementedError): | ||
| pd.eval('p + 1', parser=parser, engine=engine) | ||
|
|
||
| def test_raise_on_panel4d_with_multiindex(self, parser, engine): | ||
| tm.skip_if_no_ne() |
|
|
||
| @classmethod | ||
| def setup_class(cls): | ||
| super(TestDataFrameEvalPythonPandas, cls).setup_class() |
There was a problem hiding this comment.
The call to the super setup_class method inadvertently skipped this class of tests on systems that did not have numexpr even though that isn't required for these. Fixed with commit
WillAyd
force-pushed
the
skipif-no-lzma-ne
branch
from
4e8b6c7 to
0dee6ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #18820 +/- ##
==========================================
- Coverage 91.64% 91.63% -0.02%
==========================================
Files 154 154
Lines 51408 51402 -6
==========================================
- Hits 47113 47100 -13
- Misses 4295 4302 +7
Continue to review full report at Codecov.
|
|
thanks @WillAyd keep em coming! |
git diff upstream/master -u -- "*.py" | flake8 --diff