Skip to content

Centralize arithmetic tests for datetime/timedelta series #18809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

jbrockmendel
Copy link
Member

No tests were harming in the making of this PR.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

Line 561:17: E741 ambiguous variable name 'l'
Line 564:17: E741 ambiguous variable name 'l'
Line 1390:13: E722 do not use bare except'

@codecov
Copy link

codecov bot commented Dec 17, 2017

Codecov Report

Merging #18809 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18809      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51430    51430              
==========================================
- Hits        47131    47122       -9     
- Misses       4299     4308       +9
Flag Coverage Δ
#multiple 89.49% <ø> (ø) ⬆️
#single 40.83% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.68% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f1e71...f2a8948. Read the comment docs.

@gfyoung gfyoung added Clean Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels Dec 17, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 18, 2017
@jreback jreback merged commit fb178fc into pandas-dev:master Dec 18, 2017
@jreback
Copy link
Contributor

jreback commented Dec 18, 2017

thanks. so then you want another pass to parameterize some of these?

@jbrockmendel jbrockmendel deleted the test_ops branch December 18, 2017 15:19
@jbrockmendel
Copy link
Member Author

so then you want another pass to parameterize some of these?

Yah, plus break up by op. Ultimately I want to make sure same set of cases get tested for the datetimelike series as for the datetimelike indexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants