DOC: standardizing docstrings to use pd.DataFrame #18788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18788 +/- ##
==========================================
- Coverage 91.63% 91.62% -0.02%
==========================================
Files 154 154
Lines 51419 51428 +9
==========================================
Hits 47120 47120
- Misses 4299 4308 +9
Continue to review full report at Codecov.
|
gfyoung
reviewed
Dec 15, 2017
pandas/core/frame.py
Outdated
| @@ -3780,7 +3780,7 @@ def nlargest(self, n, columns, keep='first'): | |||
|
|
|||
| Examples | |||
| -------- | |||
| >>> df = DataFrame({'a': [1, 10, 8, 11, -1], | |||
| >>> df = pd.DataFrame({'a': [1, 10, 8, 11, -1], | |||
| ... 'b': list('abdce'), | |||
There was a problem hiding this comment.
Although this won't fail, but style-wise, notice how the "a", "b", and "c" rows are aligned and start at that same location on their respective lines. Let's keep it that way (i.e. adjust the "b" and "c" rows).
There was a problem hiding this comment.
Follow this comment for one of your other fixes down below (the "column=['a', 'b']").
jorisvandenbossche
approved these changes
Dec 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff