TST: Skip if Decorators for Localpath and Pathlib #18765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18765 +/- ##
==========================================
- Coverage 91.62% 91.61% -0.02%
==========================================
Files 154 153 -1
Lines 51427 51359 -68
==========================================
- Hits 47122 47052 -70
- Misses 4305 4307 +2
Continue to review full report at Codecov.
|
jreback
approved these changes
Dec 14, 2017
pandas/util/_test_decorators.py
Outdated
| @@ -94,6 +94,15 @@ def _skip_if_not_us_locale(): | |||
| return True | |||
|
|
|||
|
|
|||
| def skip_if_no(package, min_version=None): | |||
| def decorated_func(func): | |||
There was a problem hiding this comment.
can you add a doc-string here
16 tasks
WillAyd
force-pushed
the
skip-if-pkgs
branch
from
b0c5072 to
53d5737
Compare
|
@jreback one failure on travis but it doesn't look related. Everything else green |
|
thanks! |
This was referenced Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThis push should knock out the
pathlibandlocalpathskip if functions. Rather than creating them as their own marks, I've created a generic decorator that accepts a package and optionally a min_version as its arguments. With that, it returns a function marked with theskip_ifdecorator that callssafe_importto validate whether or not the function should be skipped.This isn't applicable to all of the skip_if decorators because some of them have post-processing they do after import (see the matplotlib decorators) but for very generic import checks this could scale better in the future