Skip to content

CLN: remove doc/plots directory (dead code) #18751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

topper-123
Copy link
Contributor

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

As part of my work on #18723, I've stumbled upon the doc/plots directory. I've searched for usages of files in this directory and have turned up blanks only, so this whole directory seems to be dead code. I assume the dir existed and had uses from the time before @savefig could be used in ipython directives, and now is outdated.

As the pandas docs now relies on @savefig decorators, I propose just removing this directory.

@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #18751 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18751      +/-   ##
==========================================
- Coverage   91.59%   91.57%   -0.02%     
==========================================
  Files         153      153              
  Lines       51364    51364              
==========================================
- Hits        47046    47037       -9     
- Misses       4318     4327       +9
Flag Coverage Δ
#multiple 89.44% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fd22e...abaf232. Read the comment docs.

@jreback jreback added the Docs label Dec 13, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 13, 2017
@jreback jreback merged commit 22f924b into pandas-dev:master Dec 13, 2017
@jreback
Copy link
Contributor

jreback commented Dec 13, 2017

thanks!

@topper-123 topper-123 deleted the remove_doc_plots branch December 13, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants