Skip to content

Move tests that dont belong in test_offsets #18747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2017

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

Merging #18747 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18747      +/-   ##
==========================================
- Coverage   91.59%   91.57%   -0.02%     
==========================================
  Files         153      153              
  Lines       51364    51364              
==========================================
- Hits        47046    47037       -9     
- Misses       4318     4327       +9
Flag Coverage Δ
#multiple 89.44% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96439fb...55ed85a. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@6a06d50). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18747   +/-   ##
=========================================
  Coverage          ?   91.59%           
=========================================
  Files             ?      153           
  Lines             ?    51363           
  Branches          ?        0           
=========================================
  Hits              ?    47047           
  Misses            ?     4316           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.46% <ø> (?)
#single 40.75% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a06d50...98020af. Read the comment docs.

@jreback jreback added Frequency DateOffsets Testing pandas testing functions or related to the test suite labels Dec 13, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 13, 2017
@jreback
Copy link
Contributor

jreback commented Dec 13, 2017

needs a rebase, ping on green.

@jreback
Copy link
Contributor

jreback commented Dec 13, 2017

lgtm. ping on green.

@jbrockmendel
Copy link
Member Author

Ping

@jreback jreback merged commit 040470a into pandas-dev:master Dec 13, 2017
@jreback
Copy link
Contributor

jreback commented Dec 13, 2017

thanks!

@jbrockmendel jbrockmendel deleted the move_tests branch February 11, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants