Skip to content

Documentation fix for method last_valid_index #18681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Documentation fix for method last_valid_index #18681

merged 1 commit into from
Dec 8, 2017

Conversation

gabrielclow
Copy link
Contributor

Documentation was showing "Return index for first non-NA/null value" for both first_valid_index and last_valid_index methods. Fixed by switching "first" to "last"

Documentation was showing "Return index for first non-NA/null value" for both first_valid_index and last_valid_index methods. Fixed by switching "first" to "last"
@codecov
Copy link

codecov bot commented Dec 7, 2017

Codecov Report

Merging #18681 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18681      +/-   ##
==========================================
- Coverage   91.59%   91.57%   -0.02%     
==========================================
  Files         153      153              
  Lines       51257    51257              
==========================================
- Hits        46949    46941       -8     
- Misses       4308     4316       +8
Flag Coverage Δ
#multiple 89.44% <ø> (ø) ⬆️
#single 40.68% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 97.81% <ø> (-0.1%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/indexes/datetimes.py 95.59% <0%> (-0.1%) ⬇️
pandas/util/testing.py 82.01% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9629fef...ce5f740. Read the comment docs.

@jreback jreback added this to the 0.21.1 milestone Dec 8, 2017
@jreback jreback merged commit ba3a442 into pandas-dev:master Dec 8, 2017
@jreback
Copy link
Contributor

jreback commented Dec 8, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor documentation issue on pd.DataFrame.last_valid_index()
3 participants