ERR: ValueError when merging on incompatible dtypes #18674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @reidy-p! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 09, 2017 at 15:46 Hours UTC |
jreback
added
Dtype Conversions
jreback
requested changes
Dec 7, 2017
pandas/core/reshape/merge.py
Outdated
|
|
||
| # Check if we are trying to merge on obviously | ||
| # incompatible dtypes GH 9780 | ||
| msg = ("You are trying to merge on {lk_dtype} and " |
There was a problem hiding this comment.
can you do these as separate elif (rather than catch these on the big else, which should be just for the object type)
| left = df | ||
| for col in df.columns: | ||
| right = DataFrame({'A': df[col]}) | ||
| result = pd.merge(left, right, on='A') |
There was a problem hiding this comment.
can you parameterize this test
Codecov Report
@@ Coverage Diff @@
## master #18674 +/- ##
==========================================
- Coverage 91.6% 91.56% -0.05%
==========================================
Files 153 153
Lines 51273 51285 +12
==========================================
- Hits 46970 46957 -13
- Misses 4303 4328 +25
Continue to review full report at Codecov.
|
reidy-p
force-pushed
the
merge_incompat_dtypes
branch
from
d531ac5 to
0e9a975
Compare
|
rebase and looks good to go. |
reidy-p
force-pushed
the
merge_incompat_dtypes
branch
from
0e9a975 to
ba5aa95
Compare
jreback
approved these changes
Dec 8, 2017
jreback
reviewed
Dec 8, 2017
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -186,6 +186,8 @@ Other API Changes | |||
| - :func:`Series.fillna` now raises a ``TypeError`` instead of a ``ValueError`` when passed a list, tuple or DataFrame as a ``value`` (:issue:`18293`) | |||
| - :func:`pandas.DataFrame.merge` no longer casts a ``float`` column to ``object`` when merging on ``int`` and ``float`` columns (:issue:`16572`) | |||
| - The default NA value for :class:`UInt64Index` has changed from 0 to ``NaN``, which impacts methods that mask with NA, such as ``UInt64Index.where()`` (:issue:`18398`) | |||
| - Building pandas for development now requires ``cython >= 0.24`` (:issue:`18613`) | |||
There was a problem hiding this comment.
hmm this moved, can you fixup
reidy-p
force-pushed
the
merge_incompat_dtypes
branch
2 times, most recently
from
fa306e4 to
cc03f5a
Compare
reidy-p
force-pushed
the
merge_incompat_dtypes
branch
from
cc03f5a to
0ca53a5
Compare
|
thanks @reidy-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff