-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: temporary remove pyarrow example of reading subset columns #18661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/source/io.rst
Outdated
result = pd.read_parquet('example_fp.parquet', engine='fastparquet') | ||
result = pd.read_parquet('example_pa.parquet', engine='pyarrow') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also switched the order here, as it is the last one for which the dtypes are shown, and pyarrow
preserves timezones while fastparquet
does not, and it is nice to show this capability of pyarrow
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this change here, left this for #18662, so this PR can more easily be reverted.
6e901aa
to
18002a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #18661 +/- ##
==========================================
+ Coverage 91.57% 91.57% +<.01%
==========================================
Files 153 153
Lines 51210 51210
==========================================
+ Hits 46894 46897 +3
+ Misses 4316 4313 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18661 +/- ##
==========================================
+ Coverage 91.57% 91.57% +<.01%
==========================================
Files 153 153
Lines 51210 51210
==========================================
+ Hits 46894 46897 +3
+ Misses 4316 4313 -3
Continue to review full report at Codecov.
|
thanks! should we open an issue to revert this (at the appropriate time)? |
We can keep #18628 open for that |
…ns (pandas-dev#18661)" This reverts commit 695e893.
xref #18628.
Until pyarrow 0.8 is released, I propose to just show the example with fastparquet. Once pyarrow 0.8 is released, we can revert this change.