Skip to content

DOC: temporary remove pyarrow example of reading subset columns #18661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

jorisvandenbossche
Copy link
Member

xref #18628.

Until pyarrow 0.8 is released, I propose to just show the example with fastparquet. Once pyarrow 0.8 is released, we can revert this change.

@jorisvandenbossche jorisvandenbossche added this to the 0.21.1 milestone Dec 6, 2017
result = pd.read_parquet('example_fp.parquet', engine='fastparquet')
result = pd.read_parquet('example_pa.parquet', engine='pyarrow')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also switched the order here, as it is the last one for which the dtypes are shown, and pyarrow preserves timezones while fastparquet does not, and it is nice to show this capability of pyarrow)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this change here, left this for #18662, so this PR can more easily be reverted.

@codecov
Copy link

codecov bot commented Dec 6, 2017

Codecov Report

Merging #18661 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18661      +/-   ##
==========================================
+ Coverage   91.57%   91.57%   +<.01%     
==========================================
  Files         153      153              
  Lines       51210    51210              
==========================================
+ Hits        46894    46897       +3     
+ Misses       4316     4313       -3
Flag Coverage Δ
#multiple 89.43% <ø> (+0.02%) ⬆️
#single 40.67% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdba133...18002a0. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 6, 2017

Codecov Report

Merging #18661 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18661      +/-   ##
==========================================
+ Coverage   91.57%   91.57%   +<.01%     
==========================================
  Files         153      153              
  Lines       51210    51210              
==========================================
+ Hits        46894    46897       +3     
+ Misses       4316     4313       -3
Flag Coverage Δ
#multiple 89.43% <ø> (+0.02%) ⬆️
#single 40.67% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdba133...18002a0. Read the comment docs.

@jreback jreback merged commit 695e893 into pandas-dev:master Dec 7, 2017
@jreback
Copy link
Contributor

jreback commented Dec 7, 2017

thanks! should we open an issue to revert this (at the appropriate time)?

@jorisvandenbossche
Copy link
Member Author

We can keep #18628 open for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO Parquet parquet, feather
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants