remove datetime.pxd #18654
remove datetime.pxd #18654
Conversation
| @@ -71,3 +75,6 @@ cdef int64_t pydate_to_dt64(date val, pandas_datetimestruct *dts) | |||
| cdef npy_datetime get_datetime64_value(object obj) nogil | |||
| cdef npy_timedelta get_timedelta64_value(object obj) nogil | |||
| cdef PANDAS_DATETIMEUNIT get_datetime64_unit(object obj) nogil | |||
|
|
|||
| cdef int _string_to_dts(object val, pandas_datetimestruct* dts, | |||
There was a problem hiding this comment.
can deprivatize at some point
There was a problem hiding this comment.
Yah I’m currently running asv on a proposed change to string_to_dts that would make to_datetime and Timestamp behavior more similar (or at least make the dissimilarity more obvious)
Codecov Report
@@ Coverage Diff @@
## master #18654 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.02%
==========================================
Files 153 153
Lines 51210 51221 +11
==========================================
+ Hits 46894 46896 +2
- Misses 4316 4325 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18654 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.02%
==========================================
Files 153 153
Lines 51210 51210
==========================================
- Hits 46894 46885 -9
- Misses 4316 4325 +9
Continue to review full report at Codecov.
|
|
Ping |
|
|
||
| cdef inline int _string_to_dts(object val, pandas_datetimestruct* dts, | ||
| int* out_local, int* out_tzoffset) except? -1: | ||
| cdef: |
There was a problem hiding this comment.
when you do change this, pls add doc-string (and same below)
| cdef inline int _cstring_to_dts(char *val, int length, | ||
| pandas_datetimestruct* dts, | ||
| int* out_local, int* out_tzoffset) except? -1: | ||
| # Note: without this "extra layer" between _string_to_dts |
There was a problem hiding this comment.
have to investigate this, it is pretty weird
|
thanks! pls make note of those 2 comments above on your list. |
There is an unrelated 2-line edit in hashing.pyx that gets rid of a compiler warning.