-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Categorical data fails to load from hdf when all columns are NaN #18652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3f07908
Fixed #18413, but test case not passing
ssche 7a4f93a
Fixed test case (#18413)
ssche 8540a4a
Removed trailing whitespace
ssche 928c258
Removed unnecessary dataframe copy
ssche b3766f7
Update whatsnew section
ssche 52dc141
Moved whatsnew entry to 0.21.1
ssche ea89a7c
Merge branch 'master' into gh18413
ssche 551f0a2
Merge branch 'master' into gh18413
ssche e6aad40
Addressed requested changes
ssche 7cf7336
Merge branch 'master' into gh18413
ssche a69ea02
Merge branch 'master' into gh18413
ssche 538e7fe
Merge branch 'master' into PR_TOOL_MERGE_PR_18652
jreback b2ac7c4
lint fixes
jreback File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,3 +106,4 @@ doc/build/html/index.html | |
doc/tmp.sv | ||
doc/source/styled.xlsx | ||
doc/source/templates/ | ||
env/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add another column with an array like
pd.Series([None]* 3, dtype=object)
. this might fail your test because the original array was an all-null object type (and no float). but let's see.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, seems to work fine.