Explicit LooseVersion comps #18637
Merged
Explicit LooseVersion comps #18637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Compat
|
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #18637 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.02%
==========================================
Files 155 155
Lines 51255 51255
==========================================
- Hits 46948 46939 -9
- Misses 4307 4316 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18637 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.02%
==========================================
Files 153 153
Lines 51221 51221
==========================================
- Hits 46917 46908 -9
- Misses 4304 4313 +9
Continue to review full report at Codecov.
|
|
@jreback all green |
pandas/core/computation/check.py
Outdated
| @@ -7,7 +7,8 @@ | |||
| try: | |||
| import numexpr as ne | |||
| ver = ne.__version__ | |||
| _NUMEXPR_INSTALLED = ver >= LooseVersion(_MIN_NUMEXPR_VERSION) | |||
| _NUMEXPR_INSTALLED = LooseVersion(ver) >= \ | |||
| LooseVersion(_MIN_NUMEXPR_VERSION) | |||
There was a problem hiding this comment.
Please use (..) for line continuation instead of \ (but here maybe you can also add the 'LooseVersion' on the line above (ver = LooseVersion(ne.__version__) to avoid the need of a line continuation)
There was a problem hiding this comment.
Was trying to keep all LooseVersion comps on the same line, but changed this back to put the one LooseVersion back on the line above for readability.
pandas/io/parquet.py
Outdated
| self._pyarrow_lt_050 = LooseVersion(pyarrow.__version__) < '0.5.0' | ||
| self._pyarrow_lt_060 = LooseVersion(pyarrow.__version__) < '0.6.0' | ||
| self._pyarrow_lt_050 = LooseVersion(pyarrow.__version__) < \ | ||
| LooseVersion('0.5.0') |
| @@ -37,7 +37,8 @@ def testit(): | |||
| except ImportError: | |||
| pytest.skip("no numexpr") | |||
| else: | |||
| if ne.__version__ < LooseVersion(_MIN_NUMEXPR_VERSION): | |||
| if LooseVersion(ne.__version__) < \ | |||
WillAyd
force-pushed
the
loose-version-cmp
branch
from
f0b73f8 to
867da74
Compare
|
Hello @WillAyd! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 06, 2017 at 01:11 Hours UTC |
WillAyd
force-pushed
the
loose-version-cmp
branch
from
867da74 to
3d6b2d7
Compare
jreback
requested changes
Dec 6, 2017
| @@ -37,7 +37,9 @@ def testit(): | |||
| except ImportError: | |||
| pytest.skip("no numexpr") | |||
| else: | |||
| if ne.__version__ < LooseVersion(_MIN_NUMEXPR_VERSION): | |||
| if ( | |||
pandas/tests/frame/test_rank.py
Outdated
| @@ -212,7 +212,9 @@ def test_rank_methods_frame(self): | |||
| sprank = sprank.astype(np.float64) | |||
| expected = DataFrame(sprank, columns=cols) | |||
|
|
|||
| if LooseVersion(scipy.__version__) >= '0.17.0': | |||
| if ( | |||
WillAyd
force-pushed
the
loose-version-cmp
branch
from
3d6b2d7 to
c2cd226
Compare
WillAyd
force-pushed
the
loose-version-cmp
branch
from
c2cd226 to
87b4c42
Compare
jreback
approved these changes
Dec 6, 2017
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff