-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: support non default indexes in writing to Parquet #18629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 13 commits into
pandas-dev:master
from
dhirschfeld:parquet-non-default-indexes
Dec 11, 2017
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4bf7f56
Allow non-default indexes in to_parquet.
dhirschfeld 7a6d9a9
Fixed test_write_with_index on Windows
dhirschfeld 1496ef6
Fix test_write_with_index to work with fastparquet
dhirschfeld 9c8cfb7
Fix linting issues
dhirschfeld 60124ac
Added wahtsnew entry for 0.21.1
dhirschfeld 03941b1
Merge remote-tracking branch 'upstream/master' into pr/18629
jorisvandenbossche d8a27e1
move whatsnew note to parquet section
jorisvandenbossche cd26110
undo version changes in ci and install docs
jorisvandenbossche 1acb00c
undo testing changes for old pyarrow versions
jorisvandenbossche 0f7b526
fix test for older versions of pyarrow
jorisvandenbossche 67dffde
use read_pandas for pyarrow < 0.7
jorisvandenbossche 79de86b
further clean-up
jorisvandenbossche 0fbdc14
style update
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For fastparquet I haven't bothered reading the metadata to pull out the index columns since even if you do you still hit the
NotImplementedError
. I figure if fastparquet do add support for multi-indexes they might implement a solution similar to pyarrow so that the user doesn't have to introspect the metadata to reconstruct the correct DataFrame.