Skip to content

BLD: Bump Cython version from 0.23 to 0.24 #18623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2017
Merged

BLD: Bump Cython version from 0.23 to 0.24 #18623

merged 2 commits into from
Dec 4, 2017

Conversation

jschendel
Copy link
Member

@jschendel jschendel commented Dec 4, 2017 •
edited
Loading

For the whatsnew:

  • Used the same whatsnew message as was used during the last cython version bump in 0.20
  • Moved some previous entries that were under the main "Backwards incompatible API changes" section to the "Other API Changes" subsection.

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18623 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18623      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
Flag Coverage Δ
#multiple 89.32% <ø> (ø) ⬆️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...97cc75f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18623 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18623      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
Flag Coverage Δ
#multiple 89.32% <ø> (ø) ⬆️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...97cc75f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2017 •
edited
Loading

Codecov Report

Merging #18623 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18623      +/-   ##
==========================================
- Coverage   91.59%   91.58%   -0.02%     
==========================================
  Files         155      155              
  Lines       51255    51255              
==========================================
- Hits        46949    46941       -8     
- Misses       4306     4314       +8
Flag Coverage Δ
#multiple 89.44% <ø> (ø) ⬆️
#single 40.67% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.68% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c903d5...d7fd50c. Read the comment docs.

jorisvandenbossche
jorisvandenbossche reviewed Dec 4, 2017
View reviewed changes
doc/source/whatsnew/v0.22.0.txt Outdated
+--------------+-----------------+----------+
| Package | Minimum Version | Required |
+==============+=================+==========+
| Cython | 0.24 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should necessarily be mentioned that prominent (in the table), as it is only a development dependency, not a user dependency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, this just needs a mention in api breaking, not a sub-section

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

jreback
jreback requested changes Dec 4, 2017
View reviewed changes
doc/source/whatsnew/v0.22.0.txt Outdated
+--------------+-----------------+----------+
| Package | Minimum Version | Required |
+==============+=================+==========+
| Cython | 0.24 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, this just needs a mention in api breaking, not a sub-section

@jreback jreback added the Build Library building on various platforms label Dec 4, 2017
@jschendel jschendel force-pushed the bump-cython-version branch from 97cc75f to d7fd50c Compare December 4, 2017 14:58
@jreback jreback added this to the 0.22.0 milestone Dec 4, 2017
@jreback
Copy link
Contributor

jreback commented Dec 4, 2017

lgtm. ping on green.

@jschendel
Copy link
Member Author

ping @jreback : green

@jorisvandenbossche jorisvandenbossche merged commit a764663 into pandas-dev:master Dec 4, 2017
@jorisvandenbossche
Copy link
Member

@jschendel thanks!

@jschendel jschendel deleted the bump-cython-version branch December 4, 2017 20:17
@jschendel jschendel mentioned this pull request Jul 1, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

BLD: Bump Cython version from 0.23 to 0.24
3 participants
@jschendel @jreback @jorisvandenbossche