Skip to content

DOC: Removing keep=False from docs on nlargest/nsmallest #18617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

AaronCritchley
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18617 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18617      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
Flag Coverage Δ
#multiple 89.32% <ø> (ø) ⬆️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 94.8% <ø> (ø) ⬆️
pandas/core/frame.py 97.81% <ø> (-0.1%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...c8ca144. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18617 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18617      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
Flag Coverage Δ
#multiple 89.32% <ø> (ø) ⬆️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 94.8% <ø> (ø) ⬆️
pandas/core/frame.py 97.81% <ø> (-0.1%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...c8ca144. Read the comment docs.

@gfyoung gfyoung added the Docs label Dec 4, 2017
@jreback jreback added this to the 0.21.1 milestone Dec 4, 2017
@jreback jreback merged commit 73ed6de into pandas-dev:master Dec 4, 2017
@jreback
Copy link
Contributor

jreback commented Dec 4, 2017

thanks!

@AaronCritchley AaronCritchley deleted the DOC-18559 branch December 4, 2017 12:17
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: .nlargest/smallest docs specify keep=False as valid parameter
4 participants