Skip to content

DOC: Give python3 precedence over py2 in the install notes #18603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Dec 2, 2017

Currently the install notes show python 2 more prominently than Python 3. I suggest reversing that.

The argument is that pandas has pledged to drop support for Python 2 in 2020, and that the general transition to python 3 is now well under way (Django has gone py3 only and numpy will only develop new feature for Python3 from 1. jan. 2019 etc).

@codecov
Copy link

codecov bot commented Dec 2, 2017

Codecov Report

Merging #18603 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18603      +/-   ##
==========================================
- Coverage   91.46%   91.44%   -0.03%     
==========================================
  Files         157      157              
  Lines       51439    51439              
==========================================
- Hits        47051    47040      -11     
- Misses       4388     4399      +11
Flag Coverage Δ
#multiple 89.31% <ø> (-0.01%) ⬇️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/util/testing.py 81.99% <0%> (-0.2%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e16818...3e70f25. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 2, 2017

Codecov Report

Merging #18603 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18603      +/-   ##
==========================================
- Coverage   91.57%   91.42%   -0.15%     
==========================================
  Files         153      157       +4     
  Lines       51210    51449     +239     
==========================================
+ Hits        46894    47039     +145     
- Misses       4316     4410      +94
Flag Coverage Δ
#multiple 89.3% <ø> (-0.12%) ⬇️
#single 40.6% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/io/excel.py 80.39% <0%> (-9.74%) ⬇️
pandas/compat/__init__.py 58.18% <0%> (-0.59%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/plotting/_timeseries.py 60.73% <0%> (-0.1%) ⬇️
pandas/tseries/offsets.py 96.9% <0%> (-0.05%) ⬇️
pandas/core/indexes/datetimelike.py 97.11% <0%> (-0.02%) ⬇️
pandas/core/indexing.py 92.8% <0%> (-0.01%) ⬇️
pandas/core/series.py 94.8% <0%> (-0.01%) ⬇️
pandas/plotting/_compat.py 62% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdba133...a5595ee. Read the comment docs.

@gfyoung gfyoung added the Docs label Dec 3, 2017
Debian, stable, `official Debian repository <http://packages.debian.org/search?keywords=pandas&searchon=names&suite=all&section=all>`__ , ``sudo apt-get install python3-pandas``
Debian & Ubuntu, unstable (latest packages), `NeuroDebian <http://neuro.debian.net/index.html#how-to-use-this-repository>`__ , ``sudo apt-get install python3-pandas``
Ubuntu, stable, `official Ubuntu repository <http://packages.ubuntu.com/search?keywords=pandas&searchon=names&suite=all&section=all>`__ , ``sudo apt-get install python3-pandas``
Ubuntu, unstable (daily builds), `PythonXY PPA <https://code.launchpad.net/~pythonxy/+archive/pythonxy-devel>`__; activate by: ``sudo add-apt-repository ppa:pythonxy/pythonxy-devel && sudo apt-get update``, ``sudo apt-get install python3-pandas``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unrelated to the actual PR, but this one can just be removed I think, it's not really up to date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just let people use pip/conda/source if they want to install the newest on linux?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I would also de-emphasize installing from the linux repos anyhow, using pip/conda is supported virtually everywhere now adays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made proposal where (1) we're showing how to install from the stable repos, (2) installing from unstable is removed, and (3) it's generally recommended to install from pip or conda.

The thinking is that this shows that repo installation is possible if needed (e.g. a company has a security policy to disallow installation from pip, while repos are verified by the distros and therefore trusted), while still showing that pip/conda installation is recommended over repo installation.

@jreback jreback added this to the 0.21.1 milestone Dec 3, 2017
@topper-123 topper-123 force-pushed the install_py3 branch 2 times, most recently from a20dd81 to d4f7ad2 Compare December 3, 2017 19:22

.. csv-table::
:header: "Distribution", "Status", "Download / Repository Link", "Install method"
:widths: 10, 10, 20, 50


Debian, stable, `official Debian repository <http://packages.debian.org/search?keywords=pandas&searchon=names&suite=all&section=all>`__ , ``sudo apt-get install python-pandas``
Debian & Ubuntu, unstable (latest packages), `NeuroDebian <http://neuro.debian.net/index.html#how-to-use-this-repository>`__ , ``sudo apt-get install python-pandas``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep neurodebian, as this one is up to date and I know it is actually used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

@jorisvandenbossche jorisvandenbossche changed the title DOC: Give python3 precedence over py2 in the ínstall notes DOC: Give python3 precedence over py2 in the install notes Dec 6, 2017
@jorisvandenbossche jorisvandenbossche merged commit 3857446 into pandas-dev:master Dec 6, 2017
@jorisvandenbossche
Copy link
Member

@topper-123 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants