-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Give python3 precedence over py2 in the install notes #18603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18603 +/- ##
==========================================
- Coverage 91.46% 91.44% -0.03%
==========================================
Files 157 157
Lines 51439 51439
==========================================
- Hits 47051 47040 -11
- Misses 4388 4399 +11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18603 +/- ##
==========================================
- Coverage 91.57% 91.42% -0.15%
==========================================
Files 153 157 +4
Lines 51210 51449 +239
==========================================
+ Hits 46894 47039 +145
- Misses 4316 4410 +94
Continue to review full report at Codecov.
|
doc/source/install.rst
Outdated
Debian, stable, `official Debian repository <http://packages.debian.org/search?keywords=pandas&searchon=names&suite=all§ion=all>`__ , ``sudo apt-get install python3-pandas`` | ||
Debian & Ubuntu, unstable (latest packages), `NeuroDebian <http://neuro.debian.net/index.html#how-to-use-this-repository>`__ , ``sudo apt-get install python3-pandas`` | ||
Ubuntu, stable, `official Ubuntu repository <http://packages.ubuntu.com/search?keywords=pandas&searchon=names&suite=all§ion=all>`__ , ``sudo apt-get install python3-pandas`` | ||
Ubuntu, unstable (daily builds), `PythonXY PPA <https://code.launchpad.net/~pythonxy/+archive/pythonxy-devel>`__; activate by: ``sudo add-apt-repository ppa:pythonxy/pythonxy-devel && sudo apt-get update``, ``sudo apt-get install python3-pandas`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit unrelated to the actual PR, but this one can just be removed I think, it's not really up to date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just let people use pip/conda/source if they want to install the newest on linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I would also de-emphasize installing from the linux repos anyhow, using pip/conda
is supported virtually everywhere now adays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made proposal where (1) we're showing how to install from the stable repos, (2) installing from unstable is removed, and (3) it's generally recommended to install from pip or conda.
The thinking is that this shows that repo installation is possible if needed (e.g. a company has a security policy to disallow installation from pip, while repos are verified by the distros and therefore trusted), while still showing that pip/conda installation is recommended over repo installation.
a20dd81
to
d4f7ad2
Compare
|
||
.. csv-table:: | ||
:header: "Distribution", "Status", "Download / Repository Link", "Install method" | ||
:widths: 10, 10, 20, 50 | ||
|
||
|
||
Debian, stable, `official Debian repository <http://packages.debian.org/search?keywords=pandas&searchon=names&suite=all§ion=all>`__ , ``sudo apt-get install python-pandas`` | ||
Debian & Ubuntu, unstable (latest packages), `NeuroDebian <http://neuro.debian.net/index.html#how-to-use-this-repository>`__ , ``sudo apt-get install python-pandas`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep neurodebian, as this one is up to date and I know it is actually used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done.
d4f7ad2
to
a5595ee
Compare
@topper-123 Thanks! |
Currently the install notes show python 2 more prominently than Python 3. I suggest reversing that.
The argument is that pandas has pledged to drop support for Python 2 in 2020, and that the general transition to python 3 is now well under way (Django has gone py3 only and numpy will only develop new feature for Python3 from 1. jan. 2019 etc).