-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Series.rank modifies inplace with NaT #18576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e82b128
Copy data.values when ranking
GuessWhoSamFoo d1cc880
WIP: Thinking of better way than a copy
GuessWhoSamFoo 9c07153
Rebased; copy if datetime
GuessWhoSamFoo ca5d28c
Fixed whatsnew; copy value in rank_1d
GuessWhoSamFoo aad8fb8
Added comments about mutating inplace per review
GuessWhoSamFoo caa3fa9
doc updates
jreback File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2214,3 +2214,12 @@ def test_series_broadcasting(self): | |
df_nan.clip_lower(s, axis=0) | ||
for op in ['lt', 'le', 'gt', 'ge', 'eq', 'ne']: | ||
getattr(df, op)(s_nan, axis=0) | ||
|
||
def test_series_nat_conversion(self): | ||
# GH 18521 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a 1-liner explaining this is testing non-mutataion of the input data |
||
# Check rank does not mutate DataFrame | ||
df = DataFrame(np.random.randn(10, 3), dtype='float64') | ||
expected = df.copy() | ||
df.rank() | ||
result = df | ||
tm.assert_frame_equal(result, expected) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# -*- coding: utf-8 -*- | ||
from pandas import compat | ||
from pandas import compat, Timestamp | ||
|
||
import pytest | ||
|
||
|
@@ -368,3 +368,13 @@ def test_rank_object_bug(self): | |
# smoke tests | ||
Series([np.nan] * 32).astype(object).rank(ascending=True) | ||
Series([np.nan] * 32).astype(object).rank(ascending=False) | ||
|
||
def test_rank_modify_inplace(self): | ||
# GH 18521 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
# Check rank does not mutate series | ||
s = Series([Timestamp('2017-01-05 10:20:27.569000'), NaT]) | ||
expected = s.copy() | ||
|
||
s.rank() | ||
result = s | ||
assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move to the reshaping section (n bug fix)