DOC: improve DataFrame/SeriesGroupBy.apply doc string #18534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
improve_GroupBy.apply_doc_string
branch
from
fa22906 to
55ea94a
Compare
topper-123
force-pushed
the
improve_GroupBy.apply_doc_string
branch
from
55ea94a to
675ef93
Compare
Codecov Report
@@ Coverage Diff @@
## master #18534 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.02%
==========================================
Files 164 164
Lines 49801 49804 +3
==========================================
- Hits 45494 45488 -6
- Misses 4307 4316 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18534 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.02%
==========================================
Files 164 164
Lines 49801 49804 +3
==========================================
- Hits 45494 45488 -6
- Misses 4307 4316 +9
Continue to review full report at Codecov.
|
|
thanks! |
|
Thanks and thanks for all the help, you're giving! When is 0.21.1 planned for release? |
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
(cherry picked from commit 2a0e54b)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
(cherry picked from commit 2a0e54b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThe doc strings for the
applymethod on GroupBy objects are currently IMO difficult to "translate" into working code. This PR proposes making the doc string more practical, including: