Skip to content

Improved description of seaborn #18495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2017
Merged

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Nov 26, 2017

The pandas docs send a surprising amount of traffic towards seaborn, but
I've never thought that the existing description communicates the
goals/advantages of seaborn all that well. Please consider this revised
copy.

I also swapped the ordering of seaborn/py-ggplot, because it looks like
that package has stalled out a bit, but I'm happy to revert the
reordering if it bothers people.

The pandas docs send a surprising amount of traffic towards seaborn, but
I've never thought that the existing description communicates the
goals/advantages of seaborn all that well. Please consider this revised
copy.

I also swapped the ordering of seaborn/py-ggplot, because it looks like
that package has stalled out a bit, but I'm happy to revert the
reordering if it bothers people.
@jreback jreback added this to the 0.21.1 milestone Nov 26, 2017
@jreback
Copy link
Contributor

jreback commented Nov 26, 2017

lgtm. @TomAugspurger

@codecov
Copy link

codecov bot commented Nov 26, 2017

Codecov Report

Merging #18495 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18495      +/-   ##
==========================================
+ Coverage    91.3%   91.32%   +0.02%     
==========================================
  Files         163      163              
  Lines       49781    49781              
==========================================
+ Hits        45451    45463      +12     
+ Misses       4330     4318      -12
Flag Coverage Δ
#multiple 89.12% <ø> (+0.02%) ⬆️
#single 40.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f41e6...ba036c5. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 26, 2017

Codecov Report

Merging #18495 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18495      +/-   ##
==========================================
+ Coverage    91.3%   91.32%   +0.02%     
==========================================
  Files         163      163              
  Lines       49781    49781              
==========================================
+ Hits        45451    45463      +12     
+ Misses       4330     4318      -12
Flag Coverage Δ
#multiple 89.12% <ø> (+0.02%) ⬆️
#single 40.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f41e6...ba036c5. Read the comment docs.

@jreback jreback merged commit 5f7d86c into pandas-dev:master Nov 26, 2017
@jreback
Copy link
Contributor

jreback commented Nov 26, 2017

thanks @mwaskom

@mwaskom mwaskom deleted the seaborn_description branch November 26, 2017 15:49
@jorisvandenbossche
Copy link
Member

We should actually also update the ggplot -> ggpy, or rather add the much more active https://github.com/has2k1/plotnine

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants