Skip to content

WIP: Pass missing tz arg in _parsed_string_to_bounds #18471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jbrockmendel
Copy link
Member

The WIP part is finding a test case that fails under the status quo.

@jreback
Copy link
Contributor

jreback commented Nov 24, 2017

generally you can simply test things locally until you are ready to put up a PR, or simply run them on your own travis branch the same.

@jbrockmendel
Copy link
Member Author

I generally do run the tests locally before pushing (and did this time as well). The "WIP" part is that I'd like to find a new test that works with this fix but fails without it.

@codecov
Copy link

codecov bot commented Nov 25, 2017

Codecov Report

Merging #18471 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18471      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.02%     
==========================================
  Files         163      163              
  Lines       49700    49704       +4     
==========================================
- Hits        45407    45402       -5     
- Misses       4293     4302       +9
Flag Coverage Δ
#multiple 89.14% <100%> (ø) ⬆️
#single 39.66% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 95.51% <100%> (+0.01%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaee541...f080bd1. Read the comment docs.

@gfyoung gfyoung added Bug Internals Related to non-user accessible pandas implementation Timezones Timezone data dtype labels Nov 27, 2017
@jreback jreback closed this Nov 28, 2017
@jreback
Copy link
Contributor

jreback commented Nov 28, 2017

not sure of the point of this PR.

@jbrockmendel jbrockmendel mentioned this pull request Nov 28, 2017
59 tasks
@jbrockmendel jbrockmendel deleted the dti_tz branch January 23, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Internals Related to non-user accessible pandas implementation Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants