Skip to content

VIS: let PeriodConverter handle datetime64 data #18468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2018
Merged

VIS: let PeriodConverter handle datetime64 data #18468

merged 4 commits into from
Jan 23, 2018

Conversation

jorisvandenbossche
Copy link
Member

xref #9053 (but doesn't solve it)

@jorisvandenbossche jorisvandenbossche mentioned this pull request Nov 24, 2017
Open
@jreback jreback added Visualization plotting Period Period data type Datetime Datetime data dtype labels Nov 25, 2017
@jreback
Copy link
Contributor

jreback commented Jan 21, 2018

can you rebase / update

@codecov
Copy link

codecov bot commented Jan 21, 2018 •
edited
Loading

Codecov Report

Merging #18468 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18468      +/-   ##
==========================================
- Coverage   91.57%   91.56%   -0.01%     
==========================================
  Files         150      150              
  Lines       48700    48702       +2     
==========================================
  Hits        44595    44595              
- Misses       4105     4107       +2
Flag Coverage Δ
#multiple 89.93% <ø> (-0.01%) ⬇️
#single 41.71% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <ø> (ø) ⬆️
pandas/util/testing.py 84.24% <0%> (-0.22%) ⬇️
pandas/core/nanops.py 96.69% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba65ca...f20f999. Read the comment docs.

jreback
jreback requested changes Jan 21, 2018
View reviewed changes
pandas/tests/plotting/test_datetimelike.py Outdated
@@ -1449,6 +1449,17 @@ def test_overlapping_datetime(self):
s2.plot(ax=ax)
s1.plot(ax=ax)

@pytest.mark.xfail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a reason to the xfail (ref an issue)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue is already linked, see comment on first line of test (or do you mean in the xfail message itself?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you normally provide a reason= in the xfail itself, which then prints out when the tests run

@jreback jreback added this to the 0.23.0 milestone Jan 22, 2018
@jreback
Copy link
Contributor

jreback commented Jan 22, 2018

lgtm. pls add a whatsnew if you think appropriate (or not ok too).

@jorisvandenbossche jorisvandenbossche merged commit 9fdac02 into pandas-dev:master Jan 23, 2018
@jorisvandenbossche jorisvandenbossche deleted the plot-periodconverter-datetime64 branch January 23, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Period Period data type Visualization plotting
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @jreback