-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: ASV binary ops benchmark #18444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18444 +/- ##
==========================================
- Coverage 91.34% 91.32% -0.02%
==========================================
Files 163 163
Lines 49717 49717
==========================================
- Hits 45413 45404 -9
- Misses 4304 4313 +9
Continue to review full report at Codecov.
|
goal_time = 0.2 | ||
|
||
def setup(self): | ||
self.N = 1000000 | ||
params = [None, 'US/Eastern'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://asv.readthedocs.io/en/latest/writing_benchmarks.html
we can add params_names
(here) and elsewhere (just for readibility)
e8af713
to
d102613
Compare
asv_bench/benchmarks/binary_ops.py
Outdated
def setup(self): | ||
self.N = 1000000 | ||
params = [None, 'US/Eastern'] | ||
param_names = ['timezone'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am shocked this works, seeing that the param_names
should be ['tz']
d102613
to
371138a
Compare
Yeah I have noticed ASV has some interesting quirks. Nonetheless for consistency, I changed |
thanks! |
Utilized
params
of timezones in theTimeseries
class instead of creating a subclass ofTimeseriesTZ
Division was being tested instead of modulo in
time_frame_int_mod
andtime_frame_float_mod
Added
np.random.seed(1234)
in setup classes where random data is created xref BENCH: put in np.random.seed on vbenches #8144Renamed
time_timestamp_ops_diff2
totime_timestamp_ops_diff_with_shift
Replaced the depreciated
np.random.random_integers
withnp.random.randint
Ran flake8 and replaced star imports