14350 #18380
Merged
14350 #18380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18380 +/- ##
===========================================
+ Coverage 39.61% 91.34% +51.72%
===========================================
Files 164 164
Lines 49799 49799
===========================================
+ Hits 19728 45487 +25759
+ Misses 30071 4312 -25759
Continue to review full report at Codecov.
|
|
thanks! |
|
@mpenkov in general, can you try to give PRs a more informative title ? |
| @@ -26,6 +26,7 @@ Other Enhancements | |||
| - :func:`pandas.tseries.frequencies.to_offset` now accepts leading '+' signs e.g. '+1h'. (:issue:`18171`) | |||
| - :class:`pandas.io.formats.style.Styler` now has method ``hide_index()`` to determine whether the index will be rendered in ouptut (:issue:`14194`) | |||
| - :class:`pandas.io.formats.style.Styler` now has method ``hide_columns()`` to determine whether columns will be hidden in output (:issue:`14194`) | |||
| - Improved wording of ValueError raised in :func:`Timestamp.tz_localize` function | |||
There was a problem hiding this comment.
Why is this mentioning tz_localize? Wasn't this about to_datetime ?
There was a problem hiding this comment.
You're right, I specified the wrong function name in whatsnew. I pushed an update just now. Do I need to create a new PR for it?
There was a problem hiding this comment.
hah i merged already
i’ll fix
jreback
added a commit
that referenced
this pull request
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff