move a small set of non-scalar tests out of scalar.test_timestamp #18377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Nov 20, 2017
| @@ -20,6 +21,61 @@ | |||
| START, END = datetime(2009, 1, 1), datetime(2010, 1, 1) | |||
|
|
|||
|
|
|||
| class TestTimestampEquivDateRange(object): | |||
There was a problem hiding this comment.
This class was previously at the bottom of test_timestamp.
jbrockmendel
commented
Nov 20, 2017
|
|
||
| from pandas.util.testing import assert_almost_equal | ||
|
|
||
| randn = np.random.randn | ||
|
|
||
|
|
||
| class TestDatetimeIndexLikeTimestamp(object): | ||
| # Tests for DatetimeIndex behaving like a vectorized Timestamp |
There was a problem hiding this comment.
I really like the vectorized-timestamp abstraction. It might make sense to have parallel test classes for Timestamp methods and their DatetimeIndex counterparts.
Codecov Report
@@ Coverage Diff @@
## master #18377 +/- ##
===========================================
+ Coverage 39.61% 91.34% +51.73%
===========================================
Files 164 164
Lines 49799 49733 -66
===========================================
+ Hits 19728 45430 +25702
+ Misses 30071 4303 -25768
Continue to review full report at Codecov.
|
jreback
requested changes
Nov 20, 2017
pandas/tests/frame/test_indexing.py
Outdated
| data = DataFrame(columns=columns, index=index) | ||
| t = datetime(2012, 11, 1) | ||
| ts = Timestamp(t) | ||
| data[ts] = np.nan # works |
There was a problem hiding this comment.
can you add a comparison here
|
Ping |
jreback
approved these changes
Nov 22, 2017
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from #18142 where scope got out of hand.
This PR is part of a series intended to separate non-scalar tests out of
tests.scalars.