cut/paste _Timestamp+Timestamp to tslibs.timestamps #18369
Conversation
| @@ -601,6 +602,14 @@ def pxd(name): | |||
| '_libs/tslibs/nattype'], | |||
| 'depends': np_datetime_headers, | |||
| 'sources': np_datetime_sources}, | |||
| '_libs.tslibs.timestamps': { | |||
| Convert TimeStamp to a Julian Date. | ||
| 0 Julian date is noon January 1, 4713 BC. | ||
| """ | ||
| year = self.year |
There was a problem hiding this comment.
Yah, in fact a bunch of stuff can be moved up to _Timestamp.
sure but still some things things to move to the subs :> (I know already on your TODO). in the end of the day tslibx.pyx could/should just be imports :> maybe even not that! |
|
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #18369 +/- ##
==========================================
- Coverage 91.38% 91.34% -0.05%
==========================================
Files 164 164
Lines 49797 49799 +2
==========================================
- Hits 45508 45487 -21
- Misses 4289 4312 +23
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18369 +/- ##
==========================================
- Coverage 91.36% 91.34% -0.02%
==========================================
Files 164 164
Lines 49718 49718
==========================================
- Hits 45426 45417 -9
- Misses 4292 4301 +9
Continue to review full report at Codecov.
|
|
Ping |
|
rebase |
|
ping |
| # py27 compat, see GH#17329 | ||
| return round(self.value / 1e9, 6) | ||
|
|
||
|
|
||
| cdef PyTypeObject* ts_type = <PyTypeObject*> Timestamp |
There was a problem hiding this comment.
is this needed? remove later?
There was a problem hiding this comment.
Still used in a couple places, we might be able to remove it later. Let’s get this and libmissing done and then take a look.
|
thanks! |
Then remove unused imports in tslibs.
If/when this is merged, it'll be official: we've taken tslib from a 5500 line beast down to ~1k.