remove have_setuptools branching #18349
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18349 +/- ##
==========================================
- Coverage 91.38% 91.36% -0.02%
==========================================
Files 164 164
Lines 49790 49790
==========================================
- Hits 45501 45492 -9
- Misses 4289 4298 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18349 +/- ##
==========================================
- Coverage 91.38% 91.36% -0.02%
==========================================
Files 164 164
Lines 49790 49790
==========================================
- Hits 45501 45492 -9
- Misses 4289 4298 +9
Continue to review full report at Codecov.
|
| msg = "C-source file '%s' not found." % (cfile) +\ | ||
| " Run 'setup.py cython' before sdist." | ||
| msg = ("C-source file '{cfile}' not found. Run " | ||
| "'setup.py cython' before sdist.".format(cfile=cfile)) |
|
I’m retroactively declaring this the first in a 4ish part sequence to transition to use cythonize. |
setup.py
Outdated
| if not _have_setuptools: | ||
| sys.exit("need setuptools/distribute for Py3k" | ||
| "\n$ pip install distribute") | ||
| setuptools_kwargs = {'test_suite': 'nose.collector', |
There was a problem hiding this comment.
why did you add nose.collector?
There was a problem hiding this comment.
I would completely remove this
There was a problem hiding this comment.
why did you add nose.collector?
It was already there, just lower in the file.
There was a problem hiding this comment.
I know, but I don't think its needed. remove and let's see.
There was a problem hiding this comment.
we should have a test_requires, but that's separate. can you open an issue for that.
|
Closing in favor of #18448. |
|
thanks |
git diff upstream/master -u -- "*.py" | flake8 --diff