parametrize more tests, move to test_liboffstes

[jbrockmendel]

Some tests currently in test_offsets belong in test_liboffsets, this moves them.

There is a test_shift_month in test_offsets and another in test_liboffsets. This combines them.

Continuing the process of making the big lists of tests in test_offsets use pytest.mark.parametrize. Is there any downside to doing this? e.g. when it collects the tests, will it hold them all in memory (instead of as a generator)?

• passes git diff upstream/master -u -- "*.py" | flake8 --diff

[jreback]

Continuing the process of making the big lists of tests in test_offsets use pytest.mark.parametrize. Is there any downside to doing this? e.g. when it collects the tests, will it hold them all in memory (instead of as a generator)?

no

the point is usuability, you can run very specific tests, and see exactly what fails, while exercising lots of cases.

these are silghtly more abstruse than a loop, but the above point wins.

[jreback]

in some cases you might want to use ids (with a callable) to actually name the tests more intelligently. This is sometimes nicer.

[jbrockmendel]

I didn't think so, but it was worth asking. At one point with dateutil I tried testing every combination of several parameters and RAM usage spiked during pytest test collection, had to kill the process. This was a loop that would have been harmless (albeit poorly advised for other reasons) using older nose-yield-style tests. Let me a little gunshy.

[codecov]

Codecov Report

Merging #18346 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18346      +/-   ##
==========================================
- Coverage   91.38%   91.36%   -0.02%     
==========================================
  Files         164      164              
  Lines       49790    49790              
==========================================
- Hits        45501    45492       -9     
- Misses       4289     4298       +9

Flag	Coverage Δ
#multiple	89.17% <ø> (ø)	⬆️
#single	39.53% <ø> (-0.03%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.8% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfad581...90e4c80. Read the comment docs.

[codecov]

Codecov Report

Merging #18346 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18346      +/-   ##
==========================================
- Coverage   91.38%   91.36%   -0.02%     
==========================================
  Files         164      164              
  Lines       49790    49790              
==========================================
- Hits        45501    45492       -9     
- Misses       4289     4298       +9

Flag	Coverage Δ
#multiple	89.17% <ø> (ø)	⬆️
#single	39.53% <ø> (-0.03%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.8% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfad581...90e4c80. Read the comment docs.

[jreback]

thanks!