-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: replace %s syntax with .format in core.indexing and core.internals #18331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: replace %s syntax with .format in core.indexing and core.internals #18331
Conversation
AaronCritchley
commented
Nov 16, 2017
- Progress towards CLN: replace %s formatting syntax with .format #16130
- tests added / passed
- passes git diff upstream/master -u -- "*.py" | flake8 --diff
pandas/core/internals.py
Outdated
newb.itemsize)) | ||
raise TypeError( | ||
"cannot set astype for copy = [{copy}] for dtype " | ||
"({dtype} [{itemsize}]) with smaller itemsize that " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be 'smaller itemsize than current'? If yes, would you like me to change in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Codecov Report
@@ Coverage Diff @@
## master #18331 +/- ##
==========================================
- Coverage 91.38% 91.36% -0.02%
==========================================
Files 164 164
Lines 49780 49790 +10
==========================================
+ Hits 45491 45492 +1
- Misses 4289 4298 +9
Continue to review full report at Codecov.
|
lgtm. ping when green (after than tiny change). |
@jreback last build green, change made to the error message as discussed 😄 |
thanks! |