Skip to content

CLN: replace %s syntax with .format in core.indexing and core.internals #18331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AaronCritchley
Copy link
Contributor

newb.itemsize))
raise TypeError(
"cannot set astype for copy = [{copy}] for dtype "
"({dtype} [{itemsize}]) with smaller itemsize that "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be 'smaller itemsize than current'? If yes, would you like me to change in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 17, 2017
@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #18331 into master will decrease coverage by 0.01%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18331      +/-   ##
==========================================
- Coverage   91.38%   91.36%   -0.02%     
==========================================
  Files         164      164              
  Lines       49780    49790      +10     
==========================================
+ Hits        45491    45492       +1     
- Misses       4289     4298       +9
Flag Coverage Δ
#multiple 89.17% <76.19%> (ø) ⬆️
#single 39.49% <4.76%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexing.py 92.8% <0%> (ø) ⬆️
pandas/core/internals.py 94.54% <80%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/core/generic.py 95.73% <0%> (ø) ⬆️
pandas/core/series.py 95.02% <0%> (+0.01%) ⬆️
pandas/core/sparse/series.py 95.33% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26b676...459a160. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Nov 17, 2017

lgtm. ping when green (after than tiny change).

@jreback jreback added this to the 0.22.0 milestone Nov 17, 2017
@AaronCritchley
Copy link
Contributor Author

@jreback last build green, change made to the error message as discussed 😄

@jreback jreback merged commit 0522dcc into pandas-dev:master Nov 19, 2017
@jreback
Copy link
Contributor

jreback commented Nov 19, 2017

thanks!

@AaronCritchley AaronCritchley deleted the cln-16130-format-string-core branch November 19, 2017 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants