Skip to content

MAINT: Blacklist np.array_equal in tests #18318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2017
Merged

MAINT: Blacklist np.array_equal in tests #18318

merged 3 commits into from
Nov 16, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 16, 2017

Follow-up to #18087.

@gfyoung gfyoung added Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite labels Nov 16, 2017
@gfyoung gfyoung added this to the 0.22.0 milestone Nov 16, 2017
@gfyoung
Copy link
Member Author

gfyoung commented Nov 16, 2017 •
edited
Loading

This initial commit should fail when Travis lints the codebase. I want to check to make sure that the check works before patching the expected lint failures.

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #18318 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18318      +/-   ##
==========================================
- Coverage   91.39%   91.37%   -0.02%     
==========================================
  Files         164      164              
  Lines       49808    49808              
==========================================
- Hits        45520    45511       -9     
- Misses       4288     4297       +9
Flag Coverage Δ
#multiple 89.17% <ø> (ø) ⬆️
#single 39.47% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f2a5e...38fc56e. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 16, 2017 •
edited
Loading

Codecov Report

Merging #18318 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18318      +/-   ##
==========================================
- Coverage   91.38%   91.34%   -0.05%     
==========================================
  Files         164      164              
  Lines       49780    49780              
==========================================
- Hits        45491    45470      -21     
- Misses       4289     4310      +21
Flag Coverage Δ
#multiple 89.14% <ø> (-0.03%) ⬇️
#single 39.49% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.44% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd38eea...6bd5f3c. Read the comment docs.

jreback
jreback requested changes Nov 16, 2017
View reviewed changes
ci/lint.sh Outdated
@@ -72,7 +72,7 @@ if [ "$LINT" ]; then
echo "Linting *.c and *.h DONE"

echo "Check for invalid testing"
grep -r -E --include '*.py' --exclude testing.py '(numpy|np)\.testing' pandas
grep -r -E --include '*.py' --exclude testing.py '(numpy|np)\.testing|(numpy|np)\.array_equal' pandas/tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grep -r -E --include '*.py' --exclude testing.py '(numpy|np)(\.testing|\.array_equal)' pandas/tests/

a little more consise, can you list in a comment the things we are looking, e.g

np.testing
np.array_equal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

pandas/tests/internals/test_internals.py

# with dup column support this method was taken out
# GH3679
pytest.skip("skipping for now")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem removing, though his should in theory work now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test doesn't work period. The function "split_block_at" doesn't exist anywhere.

@gfyoung
MAINT: Blacklist np.array_equal in tests
d3b84a2 
Follow-up to pandas-devgh-18087.
@gfyoung
MAINT: Remove remaining np.array_equal in tests
feb6f5a 
Test that uses the function call uses functionality
that doesn't exist anymore in pandas.
@gfyoung
MAINT: Address reviewer comments
6bd5f3c
@gfyoung gfyoung force-pushed the blacklist-array-equal branch from 38fc56e to 6bd5f3c Compare November 16, 2017 17:35
@jreback
Copy link
Contributor

jreback commented Nov 16, 2017

lgtm. merge on green.

@gfyoung gfyoung merged commit a26b676 into pandas-dev:master Nov 16, 2017
@gfyoung gfyoung deleted the blacklist-array-equal branch November 17, 2017 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyoung @jreback