Skip to content

CLN: replace %s syntax with .format in core.panel #18315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2017
Merged

CLN: replace %s syntax with .format in core.panel #18315

merged 4 commits into from
Nov 16, 2017

Conversation

AaronCritchley
Copy link
Contributor

Note, there's still a couple usages in this file in the Appender decorators, I'm planning on going through all appender/shared_docs usages in the near future to clean these up too.

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 16, 2017
jreback
jreback reviewed Nov 16, 2017
View reviewed changes
pandas/core/panel.py
@@ -1525,20 +1528,6 @@ def _extract_axis(self, data, axis=0, intersect=False):
def _add_aggregate_operations(cls, use_numexpr=True):
""" add the operations to the cls; evaluate the doc strings again """

# doc strings substitors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this replaced by something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it back in @ L1580 😄

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #18315 into master will decrease coverage by <.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18315      +/-   ##
==========================================
- Coverage   91.37%   91.36%   -0.01%     
==========================================
  Files         164      164              
  Lines       49854    49807      -47     
==========================================
- Hits        45553    45508      -45     
+ Misses       4301     4299       -2
Flag Coverage Δ
#multiple 89.17% <72.72%> (+0.01%) ⬆️
#single 39.47% <18.18%> (-0.03%) ⬇️
Impacted Files Coverage Δ
pandas/core/panel.py 97.14% <72.72%> (-0.15%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/tseries/offsets.py 96.96% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1bfd7...25c2008. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #18315 into master will decrease coverage by <.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18315      +/-   ##
==========================================
- Coverage   91.37%   91.36%   -0.01%     
==========================================
  Files         164      164              
  Lines       49854    49807      -47     
==========================================
- Hits        45553    45508      -45     
+ Misses       4301     4299       -2
Flag Coverage Δ
#multiple 89.17% <72.72%> (+0.01%) ⬆️
#single 39.47% <18.18%> (-0.03%) ⬇️
Impacted Files Coverage Δ
pandas/core/panel.py 97.14% <72.72%> (-0.15%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/tseries/offsets.py 96.96% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1bfd7...25c2008. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #18315 into master will decrease coverage by <.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18315      +/-   ##
==========================================
- Coverage   91.37%   91.36%   -0.01%     
==========================================
  Files         164      164              
  Lines       49854    49807      -47     
==========================================
- Hits        45553    45508      -45     
+ Misses       4301     4299       -2
Flag Coverage Δ
#multiple 89.17% <72.72%> (+0.01%) ⬆️
#single 39.47% <18.18%> (-0.03%) ⬇️
Impacted Files Coverage Δ
pandas/core/panel.py 97.14% <72.72%> (-0.15%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/tseries/offsets.py 96.96% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1bfd7...25c2008. Read the comment docs.

@jreback jreback added this to the 0.22.0 milestone Nov 16, 2017
@jreback jreback merged commit 6405919 into pandas-dev:master Nov 16, 2017
@jreback
Copy link
Contributor

jreback commented Nov 16, 2017

thanks!

@AaronCritchley AaronCritchley deleted the cln-16130-format-strings-panel branch November 16, 2017 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronCritchley @jreback