BUG: #12815 Always use np.nan for missing values of object dtypes #18313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18313 +/- ##
==========================================
- Coverage 91.39% 91.37% -0.02%
==========================================
Files 164 164
Lines 49854 49855 +1
==========================================
- Hits 45566 45557 -9
- Misses 4288 4298 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18313 +/- ##
==========================================
- Coverage 91.38% 91.36% -0.02%
==========================================
Files 164 164
Lines 49796 49798 +2
==========================================
- Hits 45507 45500 -7
- Misses 4289 4298 +9
Continue to review full report at Codecov.
|
jreback
added
Missing-data
pandas/tests/frame/test_reshape.py
Outdated
|
|
||
|
|
||
| def test_unstack_fill_frame_object(): | ||
| # Test unstacking with object |
There was a problem hiding this comment.
add the issue number as a comment
|
@jreback Changes made. |
|
trivial change. push & ping when green. |
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -48,6 +48,7 @@ Other API Changes | |||
| - :class:`CacheableOffset` and :class:`WeekDay` are no longer available in the ``pandas.tseries.offsets`` module (:issue:`17830`) | |||
| - `tseries.frequencies.get_freq_group()` and `tseries.frequencies.DAYS` are removed from the public API (:issue:`18034`) | |||
| - :func:`Series.truncate` and :func:`DataFrame.truncate` will raise a ``ValueError`` if the index is not sorted instead of an unhelpful ``KeyError`` (:issue:`17935`) | |||
| - `Dataframe.unstack()` will now default to filling with `np.nan` for ``object`` columns. (:issue:`12815`) | |||
There was a problem hiding this comment.
use double-backticks around np.nan
|
note if you are interested in cleaning some things up :>
Not sure of the answer here. |
|
@jreback Green. I'll open an issue for the |
|
thanks @mattayes |
git diff upstream/master -u -- "*.py" | flake8 --diffHandles the issue of unstacked object columns filling missing values with
Noneinstead ofnp.nanby modifyingpd.core.dtypes.cast.maybe_promote()to use afill_valueofnp.nan(orpd.NaT) when the originalfill_valueisNone.Let me know if you'd like me to clarify anything!