update imports; remove unused #18298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18298 +/- ##
==========================================
- Coverage 91.4% 91.38% -0.02%
==========================================
Files 164 164
Lines 49880 49880
==========================================
- Hits 45592 45583 -9
- Misses 4288 4297 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18298 +/- ##
==========================================
- Coverage 91.4% 91.38% -0.02%
==========================================
Files 164 164
Lines 49880 49880
==========================================
- Hits 45592 45583 -9
- Misses 4288 4297 +9
Continue to review full report at Codecov.
|
can we make that happen? |
| get_dst_info) | ||
| from tslibs.fields import ( | ||
| get_date_name_field, get_start_end_field, get_date_field, | ||
| build_field_sarray) |
There was a problem hiding this comment.
build_field_sarray I think can be completely removed from the codebase
There was a problem hiding this comment.
It's used in tslibs.resolution.
There are a few funcs scattered around _libs that aren't used anywhere. Didn't remove them in this PR to keep it uncontroversial. lib.arrmap and index.get_value_at come to mind.
Not that I'm aware of. I tried piping the source into flake8 via a sed replacement cimport-->import, but it still chokes when it gets to python syntax errors. Ultimately I think the effort to build+maintain a flake8 patch to handle this would be more than the effort to just manually check the cimports once in a while. |
|
Would this be easier if broken up into smaller pieces? I'm hesitant to touch the affected files while this is outstanding. |
|
thanks! |
General cleanup. flake8 doesn't catch unused cimports.
git diff upstream/master -u -- "*.py" | flake8 --diff