Skip to content

#18285 parquet io docs #18292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2017
Merged

#18285 parquet io docs #18292

merged 2 commits into from
Nov 14, 2017

Conversation

mattayes
Copy link
Contributor

@mattayes mattayes commented Nov 14, 2017 •
edited
Loading

jorisvandenbossche
jorisvandenbossche reviewed Nov 14, 2017
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small comment

doc/source/io.rst Outdated
@@ -4492,7 +4492,7 @@ dtypes, including extension dtypes such as datetime with tz.
Several caveats.

- The format will NOT write an ``Index``, or ``MultiIndex`` for the ``DataFrame`` and will raise an
error if a non-default one is provided. You can simply ``.reset_index(drop=True)`` in order to store the index.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "or reset_index(drop=True) to ignore the index" ?

@jorisvandenbossche jorisvandenbossche added this to the 0.21.1 milestone Nov 14, 2017
@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #18292 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18292      +/-   ##
==========================================
- Coverage    91.4%   91.38%   -0.02%     
==========================================
  Files         164      164              
  Lines       49880    49880              
==========================================
- Hits        45591    45583       -8     
- Misses       4289     4297       +8
Flag Coverage Δ
#multiple 89.19% <ø> (ø) ⬆️
#single 39.42% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.48% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e8527...df2c6fb. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 14, 2017 •
edited
Loading

Codecov Report

Merging #18292 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18292      +/-   ##
==========================================
- Coverage    91.4%   91.38%   -0.02%     
==========================================
  Files         164      164              
  Lines       49880    49880              
==========================================
- Hits        45591    45583       -8     
- Misses       4289     4297       +8
Flag Coverage Δ
#multiple 89.19% <ø> (ø) ⬆️
#single 39.42% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.48% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e8527...f0836da. Read the comment docs.

@mattayes
Copy link
Contributor Author

mattayes commented Nov 14, 2017 •
edited
Loading

@jorisvandenbossche Do you know what's up with those CodeCov reports? I didn't touch any of the impacted files and the changes appear to just be lines being deleted and then re-added.

@jorisvandenbossche
Copy link
Member

@mattayes you can just ignore that, codecov can be rather flaky ..

@jorisvandenbossche jorisvandenbossche merged commit 148ed63 into pandas-dev:master Nov 14, 2017
@jorisvandenbossche
Copy link
Member

@mattayes Thanks for the quick PR!

@mattayes
Copy link
Contributor Author

@jorisvandenbossche You're welcome, thanks for the quick review!

@mattayes mattayes deleted the 18285-parquet-io-docs branch November 15, 2017 18:10
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
@mattayes @TomAugspurger
DOC: Fix "drop=True" reset_index() reference in Feather and Parquet I…
4df8ee2 
…O index caveats (pandas-dev#18285) (pandas-dev#18292)

(cherry picked from commit 148ed63)
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
@mattayes @TomAugspurger
DOC: Fix "drop=True" reset_index() reference in Feather and Parquet I…
faeda18 
…O index caveats (#18285) (#18292)

(cherry picked from commit 148ed63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.21.1
Development

Successfully merging this pull request may close these issues.

DOC: Parquet IO docs don't match code
2 participants
@mattayes @jorisvandenbossche