BUG: Use float64 for row counter in rank() #18274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proinsias
changed the title
Codecov Report
@@ Coverage Diff @@
## master #18274 +/- ##
==========================================
- Coverage 91.4% 91.38% -0.03%
==========================================
Files 164 164
Lines 49878 49878
==========================================
- Hits 45590 45580 -10
- Misses 4288 4298 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18274 +/- ##
==========================================
+ Coverage 91.37% 91.38% +<.01%
==========================================
Files 164 164
Lines 49880 49880
==========================================
+ Hits 45580 45583 +3
+ Misses 4300 4297 -3
Continue to review full report at Codecov.
|
jreback
requested changes
Nov 14, 2017
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -162,5 +162,5 @@ Other | |||
| ^^^^^ | |||
|
|
|||
| - Improved error message when attempting to use a Python keyword as an identifier in a numexpr query (:issue:`18221`) | |||
| - | |||
| - Fixed incorrect maximum :func:`Series.rank` percentile for large arrays (:issue:`18271`) | |||
There was a problem hiding this comment.
Both done. Thanks!
jreback
added
the
Numeric Operations
|
When I rerun the same code from #18271, I get the same result in |
As reported in #18271, for a large `Series` `s` of `float`s, `Series.rank(pct=True).max()` may not be `<=1` as expected. This is due to the use of a `float` for the row counter. This updates the counter to use a `float64`.
|
tests |
|
pls rebase and update to comments |
|
closing as stale. if you want to continue working, pls ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffAs reported in #18271, for a large
Seriessoffloats,Series.rank(pct=True).max()may not be<=1as expected.This is due to the use of a
floatfor the row counter. This updates the counter to use afloat64.