Skip to content

DOC: updated .combine_first doc strings #18266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Nov 13, 2017

This PR updates Series.combine_first/DataFrame.combine_first doc strings. In Particular, it add some short examples to the doc strings.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Added a small comment

combined : DataFrame
See Also
--------
DataFrame.combine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a short sentence here highlighting the difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #18266 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18266      +/-   ##
==========================================
- Coverage    91.4%   91.38%   -0.02%     
==========================================
  Files         164      164              
  Lines       49883    49878       -5     
==========================================
- Hits        45595    45581      -14     
- Misses       4288     4297       +9
Flag Coverage Δ
#multiple 89.19% <ø> (-0.01%) ⬇️
#single 39.41% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 97.8% <ø> (-0.1%) ⬇️
pandas/core/series.py 95% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/indexes/multi.py 96.38% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7495e9a...0087d98. Read the comment docs.

@jorisvandenbossche jorisvandenbossche added this to the 0.21.1 milestone Nov 14, 2017
@jorisvandenbossche jorisvandenbossche merged commit 7857c68 into pandas-dev:master Nov 14, 2017
@jorisvandenbossche
Copy link
Member

Thanks!

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
@topper-123 topper-123 deleted the combine branch December 11, 2017 08:09
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants