Skip to content

TST: xfail dateutil > 2.6.1 tests #18240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2017
Merged

TST: xfail dateutil > 2.6.1 tests #18240

merged 1 commit into from
Nov 12, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Nov 12, 2017

xref #18141

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Needs Backport Testing pandas testing functions or related to the test suite labels Nov 12, 2017
@jreback jreback added this to the 0.21.1 milestone Nov 12, 2017
@jreback
Copy link
Contributor Author

jreback commented Nov 12, 2017 •
edited
Loading

cc @pganssle

these are all formats that we fallback to dateutil for guessing. These are now returning None. Can fix our tests once I can distinguish 2.6.1 from master.
note that these are only tested this build: https://travis-ci.org/pandas-dev/pandas/jobs/300762516 (our 3.6_NUMPY_DEV build), where we test master of numpy,scipy,dateutil

@codecov
Copy link

codecov bot commented Nov 12, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@aebe2a9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18240   +/-   ##
=========================================
  Coverage          ?   91.39%           
=========================================
  Files             ?      163           
  Lines             ?    50091           
  Branches          ?        0           
=========================================
  Hits              ?    45779           
  Misses            ?     4312           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.2% <ø> (?)
#single 40.36% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebe2a9...79e1b6d. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 12, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@aebe2a9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18240   +/-   ##
=========================================
  Coverage          ?   91.39%           
=========================================
  Files             ?      163           
  Lines             ?    50091           
  Branches          ?        0           
=========================================
  Hits              ?    45779           
  Misses            ?     4312           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.2% <ø> (?)
#single 40.36% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebe2a9...79e1b6d. Read the comment docs.

@jreback jreback merged commit 40fd6b4 into pandas-dev:master Nov 12, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jreback @No-Stream
TST: xfail dateutil > 2.6.1 tests (pandas-dev#18240)
f1c2eb1 
xref pandas-dev#18141
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
@jreback @TomAugspurger
TST: xfail dateutil > 2.6.1 tests (pandas-dev#18240)
b9ed3a2 
xref pandas-dev#18141

(cherry picked from commit 40fd6b4)
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
@jreback @TomAugspurger
TST: xfail dateutil > 2.6.1 tests (#18240)
a788aec 
xref #18141

(cherry picked from commit 40fd6b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.21.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jreback @TomAugspurger