Skip to content

TST: clean up some tests issues & style #18232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2017
Merged

TST: clean up some tests issues & style #18232

merged 3 commits into from
Nov 11, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Nov 11, 2017

closes #18037

@jreback jreback added Needs Backport Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite Timezones Timezone data dtype labels Nov 11, 2017
@jreback jreback added this to the 0.21.1 milestone Nov 11, 2017
@jreback jreback mentioned this pull request Nov 11, 2017
Merged
@codecov
Copy link

codecov bot commented Nov 11, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b36dab5). Click here to learn what that means.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18232   +/-   ##
=========================================
  Coverage          ?   91.41%           
=========================================
  Files             ?      163           
  Lines             ?    50091           
  Branches          ?        0           
=========================================
  Hits              ?    45791           
  Misses            ?     4300           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.22% <70%> (?)
#single 40.36% <20%> (?)
Impacted Files Coverage Δ
pandas/core/indexes/timedeltas.py 91.17% <100%> (ø)
pandas/core/dtypes/cast.py 88.17% <64.7%> (ø)
pandas/core/series.py 95% <66.66%> (ø)
pandas/core/indexes/datetimes.py 95.48% <75%> (ø)
pandas/core/indexes/base.py 96.42% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36dab5...c20332c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Nov 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b36dab5). Click here to learn what that means.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18232   +/-   ##
=========================================
  Coverage          ?   91.41%           
=========================================
  Files             ?      163           
  Lines             ?    50091           
  Branches          ?        0           
=========================================
  Hits              ?    45791           
  Misses            ?     4300           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.22% <70%> (?)
#single 40.36% <20%> (?)
Impacted Files Coverage Δ
pandas/core/indexes/timedeltas.py 91.17% <100%> (ø)
pandas/core/dtypes/cast.py 88.17% <64.7%> (ø)
pandas/core/series.py 95% <66.66%> (ø)
pandas/core/indexes/datetimes.py 95.48% <75%> (ø)
pandas/core/indexes/base.py 96.42% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36dab5...c20332c. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 11, 2017 •
edited
Loading

Codecov Report

Merging #18232 into master will increase coverage by <.01%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18232      +/-   ##
==========================================
+ Coverage    91.4%   91.41%   +<.01%     
==========================================
  Files         163      163              
  Lines       50091    50091              
==========================================
+ Hits        45788    45791       +3     
+ Misses       4303     4300       -3
Flag Coverage Δ
#multiple 89.22% <70%> (+0.02%) ⬆️
#single 40.36% <20%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/timedeltas.py 91.17% <100%> (ø) ⬆️
pandas/core/dtypes/cast.py 88.17% <64.7%> (ø) ⬆️
pandas/core/series.py 95% <66.66%> (ø) ⬆️
pandas/core/indexes/datetimes.py 95.48% <75%> (ø) ⬆️
pandas/core/indexes/base.py 96.42% <80%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36dab5...c20332c. Read the comment docs.

@jreback jreback merged commit 96a5274 into pandas-dev:master Nov 11, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jreback @No-Stream
TST: clean up some tests issues & style (pandas-dev#18232)
b1cd540 
* STYLE: clean up flake8 exceptions

* TST: skip if no bs4 for some html tests

* TST: fix local timezone checking with .timestamp()
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
@jreback @TomAugspurger
TST: clean up some tests issues & style (pandas-dev#18232)
8ea84a8 
* STYLE: clean up flake8 exceptions

* TST: skip if no bs4 for some html tests

* TST: fix local timezone checking with .timestamp()

(cherry picked from commit 96a5274)
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
@jreback @TomAugspurger
TST: clean up some tests issues & style (#18232)
e3b958c 
* STYLE: clean up flake8 exceptions

* TST: skip if no bs4 for some html tests

* TST: fix local timezone checking with .timestamp()

(cherry picked from commit 96a5274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite Timezones Timezone data dtype
Projects
None yet
Milestone
0.21.1
Development

Successfully merging this pull request may close these issues.

TST: .timestamp() uses local timezone
2 participants
@jreback @TomAugspurger