BUG: MultiIndex not raising AttributeError with a million records #18229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Nov 11, 2017
pandas/tests/indexes/test_multi.py
Outdated
| index=pd.MultiIndex.from_tuples([(x, x) for x in r])) | ||
|
|
||
| with pytest.raises(AttributeError, | ||
| message="'Series' object has no attribute 'foo'"): |
There was a problem hiding this comment.
Let's use tm.assert_raises_regex instead.
gfyoung
reviewed
Nov 11, 2017
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -100,7 +100,7 @@ Indexing | |||
|
|
|||
| - Bug in :func:`Series.truncate` which raises ``TypeError`` with a monotonic ``PeriodIndex`` (:issue:`17717`) | |||
| - Bug in :func:`DataFrame.groupby` where key as tuple in a ``MultiIndex`` were interpreted as a list of keys (:issue:`17979`) | |||
| - | |||
| - Bug where a ``MultiIndex`` with more than a million records was not raising ``AttributeError`` as expected (:issue:`18165`) | |||
There was a problem hiding this comment.
In what context? Add something short to the end of that sentence to clarify.
gfyoung
changed the title
gfyoung
added
MultiIndex
Error Reporting
WillAyd
force-pushed
the
mill-multi-fix
branch
from
126e4ff to
457e84b
Compare
jreback
reviewed
Nov 12, 2017
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -100,7 +100,7 @@ Indexing | |||
|
|
|||
| - Bug in :func:`Series.truncate` which raises ``TypeError`` with a monotonic ``PeriodIndex`` (:issue:`17717`) | |||
| - Bug in :func:`DataFrame.groupby` where key as tuple in a ``MultiIndex`` were interpreted as a list of keys (:issue:`17979`) | |||
There was a problem hiding this comment.
I think this is ok for 0.21.1, can you move. ping on when pushed.
WillAyd
force-pushed
the
mill-multi-fix
branch
from
457e84b to
7c0fac8
Compare
|
@jreback moved to v0.21.1 |
jreback
approved these changes
Nov 12, 2017
|
thanks! |
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
…ndas-dev#18165) (pandas-dev#18229) (cherry picked from commit eb39b44)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff