Add requirement for a 1-dimensional ndarray in the pd.qcut docstring
#18211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18211 +/- ##
==========================================
+ Coverage 91.4% 91.4% +<.01%
==========================================
Files 163 163
Lines 50064 50064
==========================================
+ Hits 45760 45763 +3
+ Misses 4304 4301 -3
Continue to review full report at Codecov.
|
jreback
requested changes
Nov 10, 2017
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -78,7 +78,7 @@ Performance Improvements | |||
| Documentation Changes | |||
| ~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| - | |||
| - Add requirement for 1-dimensional ndarrays in ``pd.qcut`` docstring (:issue:`18173`) | |||
pandas/core/reshape/tile.py
Outdated
| @@ -148,7 +148,7 @@ def qcut(x, q, labels=None, retbins=False, precision=3, duplicates='raise'): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| x : ndarray or Series | |||
| x : ndarray (1-dimensional) or Series | |||
|
thanks @jdoepfert |
|
thx @jreback ! |
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
pandas-dev#18211) (cherry picked from commit a6345c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.qcutonly accepts 1-dimensional numpy arrays, which is not mentioned in the docstring. This PR updates the docstring accordingly.