-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew #18204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew #18204
Conversation
this is ok, but are you intending to actually update the current docs? |
Codecov Report
@@ Coverage Diff @@
## master #18204 +/- ##
==========================================
- Coverage 91.4% 91.38% -0.02%
==========================================
Files 163 163
Lines 50064 50064
==========================================
- Hits 45759 45751 -8
- Misses 4305 4313 +8
Continue to review full report at Codecov.
|
Well, that would also be nice. But at least backporting it to 0.21.1 will make sure it is in the 0.21 docs by the time that is released, and there will still be upgrading lots of people to 0.21 by that time. @TomAugspurger to update the current docs, I don't think it is easy to make a new build with those changes? (as then the commit tag is not correctly 0.21.0 etc). Maybe I can just edit the source html a bit if I really want it there? |
Uhm, I can just hardcode @jorisvandenbossche could you also expand the "matplotlib no longer imported"? Last item here: http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#other-api-changes Something like
|
Actually, I'll just push that to this branch. |
…1.0 whatsnew (pandas-dev#18204) * DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew * DOC: emphasize matplotlib changes
…1.0 whatsnew (pandas-dev#18204) * DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew * DOC: emphasize matplotlib changes (cherry picked from commit 85e6864)
Attempt to better highlight the change of empty Series, instead of mainly focussing now on all-NaN (given the recent issues that were raised were often about the empty case)