Skip to content

DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew #18204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Attempt to better highlight the change of empty Series, instead of mainly focussing now on all-NaN (given the recent issues that were raised were often about the empty case)

@jorisvandenbossche jorisvandenbossche added this to the 0.21.1 milestone Nov 9, 2017
@jreback
Copy link
Contributor

jreback commented Nov 10, 2017

this is ok, but are you intending to actually update the current docs?

@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #18204 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18204      +/-   ##
==========================================
- Coverage    91.4%   91.38%   -0.02%     
==========================================
  Files         163      163              
  Lines       50064    50064              
==========================================
- Hits        45759    45751       -8     
- Misses       4305     4313       +8
Flag Coverage Δ
#multiple 89.19% <ø> (ø) ⬆️
#single 40.36% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.48% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca737ac...8556b24. Read the comment docs.

@jorisvandenbossche
Copy link
Member Author

this is ok, but are you intending to actually update the current docs?

Well, that would also be nice. But at least backporting it to 0.21.1 will make sure it is in the 0.21 docs by the time that is released, and there will still be upgrading lots of people to 0.21 by that time.

@TomAugspurger to update the current docs, I don't think it is easy to make a new build with those changes? (as then the commit tag is not correctly 0.21.0 etc). Maybe I can just edit the source html a bit if I really want it there?

@TomAugspurger
Copy link
Contributor

Uhm, I can just hardcode __version__ in pandas/__init__.py before building.

@jorisvandenbossche could you also expand the "matplotlib no longer imported"? Last item here: http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#other-api-changes

Something like

Pandas no registers our datetime, datetime64, and Period converters with
matplotlib on import. Matplotlib plot methods (``plt.plot``, ``ax.plot``, ...),
will not nicely format the x-axis for ``DatetiemIndex`` or ``PeriodIndex``
values. You must explicitly register these methods:

.. ipython:: python

   from pandas.tseries import converter
   converter.register()

   fig, ax = plt.subplots()
   plt.plot(pd.date_range('2017', periods=12), range(12))

Pandas built-in ``Series.plot`` and ``DataFrame.plot`` *will* register these
on first-use (:issue:17710).

@TomAugspurger
Copy link
Contributor

Actually, I'll just push that to this branch.

@jorisvandenbossche jorisvandenbossche merged commit 85e6864 into pandas-dev:master Nov 11, 2017
@jorisvandenbossche jorisvandenbossche deleted the doc-empty-sum branch November 11, 2017 21:41
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
…1.0 whatsnew (pandas-dev#18204)

* DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew

* DOC: emphasize matplotlib changes
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
…1.0 whatsnew (pandas-dev#18204)

* DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew

* DOC: emphasize matplotlib changes

(cherry picked from commit 85e6864)
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
…1.0 whatsnew (#18204)

* DOC: clarfiy sum of empty Series case in 0.21.0 whatsnew

* DOC: emphasize matplotlib changes

(cherry picked from commit 85e6864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants