Skip to content

DOC: Remove vendored IPython.sphinext #18193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2017

Conversation

TomAugspurger
Copy link
Contributor

No description provided.

@TomAugspurger TomAugspurger added this to the 0.22.0 milestone Nov 9, 2017
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love removing code!

assume this renders the same / better?
do we need to change our requirements in any way?

@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #18193 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18193      +/-   ##
==========================================
- Coverage   91.42%   91.38%   -0.05%     
==========================================
  Files         163      163              
  Lines       50064    50064              
==========================================
- Hits        45772    45751      -21     
- Misses       4292     4313      +21
Flag Coverage Δ
#multiple 89.19% <ø> (-0.03%) ⬇️
#single 40.36% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e0b13...902b75f. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #18193 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18193      +/-   ##
==========================================
- Coverage    91.4%   91.38%   -0.03%     
==========================================
  Files         163      163              
  Lines       50064    50064              
==========================================
- Hits        45763    45751      -12     
- Misses       4301     4313      +12
Flag Coverage Δ
#multiple 89.19% <ø> (-0.03%) ⬇️
#single 40.36% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e0b13...902b75f. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

Renders the same AFAICT. Apparently the @savefig puts files in a different place now, but not a big deal.

Dependencies should all be fine. We already include IPython in our doc build, and the updates I made to contributing last week include IPython.

@TomAugspurger TomAugspurger mentioned this pull request Nov 9, 2017
15 tasks
@TomAugspurger TomAugspurger merged commit ca737ac into pandas-dev:master Nov 9, 2017
@jorisvandenbossche
Copy link
Member

Yes!

watercrossing pushed a commit to watercrossing/pandas that referenced this pull request Nov 10, 2017
* DOC: Remove vendored IPython.sphinext

* fixup
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Nov 16, 2017
jorisvandenbossche added a commit that referenced this pull request Nov 17, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
* DOC: Remove vendored IPython.sphinext

* fixup
@TomAugspurger TomAugspurger deleted the ipython-sphinx branch December 20, 2017 16:10
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants