Skip to content

Add test for #15966 #18170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

watercrossing
Copy link
Contributor

@watercrossing watercrossing commented Nov 8, 2017

@jreback jreback added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels Nov 8, 2017
@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #18170 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18170      +/-   ##
==========================================
+ Coverage    91.4%    91.4%   +<.01%     
==========================================
  Files         163      163              
  Lines       50068    50068              
==========================================
+ Hits        45764    45767       +3     
+ Misses       4304     4301       -3
Flag Coverage Δ
#multiple 89.21% <ø> (+0.02%) ⬆️
#single 40.33% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5350330...002da39. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #18170 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18170      +/-   ##
==========================================
+ Coverage    91.4%    91.4%   +<.01%     
==========================================
  Files         163      163              
  Lines       50068    50068              
==========================================
+ Hits        45764    45767       +3     
+ Misses       4304     4301       -3
Flag Coverage Δ
#multiple 89.21% <ø> (+0.02%) ⬆️
#single 40.33% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5350330...002da39. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #18170 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18170      +/-   ##
==========================================
+ Coverage    91.4%    91.4%   +<.01%     
==========================================
  Files         163      163              
  Lines       50068    50068              
==========================================
+ Hits        45764    45767       +3     
+ Misses       4304     4301       -3
Flag Coverage Δ
#multiple 89.21% <ø> (+0.02%) ⬆️
#single 40.33% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5350330...002da39. Read the comment docs.

@TomAugspurger
Copy link
Contributor

No need for a whatsnew, thanks @watercrossing.

@TomAugspurger TomAugspurger merged commit c8aad92 into pandas-dev:master Nov 8, 2017
@TomAugspurger TomAugspurger added this to the 0.22.0 milestone Nov 8, 2017
@watercrossing watercrossing deleted the tsAwareScalarComparison branch November 9, 2017 10:28
watercrossing added a commit to watercrossing/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants