-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Separate out non-scalar tests from scalar tests; move to ?? in follow-up #18142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e7d5373
Separate out non-scalar tests from scalar tests; move to ?? in follow-up
jbrockmendel f99aa04
per reviewer request, move non-scalar test classes
jbrockmendel 73e2f02
move test_timestamps-->test_timeseries per reviewer request
jbrockmendel 157c7fa
move html test per request
jbrockmendel 14810f6
move tests from test_datetime per reviewer request
jbrockmendel cb932a2
Movement per reviewer request
jbrockmendel c0a5f77
Merge branch 'master' of https://github.com/pandas-dev/pandas into sc…
jbrockmendel b575b3a
movements per reviewer request
jbrockmendel 9f06079
Merge branch 'master' of https://github.com/pandas-dev/pandas into sc…
jbrockmendel f628aef
flake8 whitespace fixup
jbrockmendel ea7d33b
Merge branch 'master' of https://github.com/pandas-dev/pandas into sc…
jbrockmendel 817281b
Merge branch 'master' of https://github.com/pandas-dev/pandas into sc…
jbrockmendel e467040
Merge branch 'master' of https://github.com/pandas-dev/pandas into
jbrockmendel 66c65c1
dummy commit to force CI
jbrockmendel f932060
Merge branch 'master' of https://github.com/pandas-dev/pandas into sc…
jbrockmendel 16ccef4
Merge branch 'master' of https://github.com/pandas-dev/pandas into sc…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so rather than move these within the same file I would like to create another directory level (like we have for indexes) and put them in separate files, e.g.
etc. much more organized to have separate units of tests in separate named files (rather than classes). be sure to update setup.py with the additional directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm amenable to that in general, but the relevantissue here is that the new classes (which I agree don't belong here) are not scalar tests at all. Some are for DatetimeIndex/TimedeltaIndex which I can figure out destinations for. I haven't looked at Series/DataFrame tests to see where those might go. Or there could be something like tests/tslibs/vectorized/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the would rather u do a PR which actually moves them to the right location rather than a temporary one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough