-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Check lossiness of floats with parse_dates #18136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18136 +/- ##
==========================================
- Coverage 91.28% 91.24% -0.04%
==========================================
Files 163 163
Lines 50122 50122
==========================================
- Hits 45752 45732 -20
- Misses 4370 4390 +20
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18136 +/- ##
==========================================
- Coverage 91.28% 91.24% -0.04%
==========================================
Files 163 163
Lines 50122 50122
==========================================
- Hits 45752 45732 -20
- Misses 4370 4390 +20
Continue to review full report at Codecov.
|
@gfyoung worth adding the |
@jreback : I'm not sure I follow you here. The tests are parametrized so that they pass regardless of whether |
right but the original issues shows a loss of precision when parse_dates=True |
Yes, the issue is fixed on |
thanks @gfyoung if you figure out where then add a reference here (not a big deal though) |
Closes pandas-devgh-2697. (cherry picked from commit e23bd24)
The examples don't fail anymore with
read_csv
, so let's add them as tests.Closes #2697.