Skip to content

TST: Check lossiness of floats with parse_dates #18136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 6, 2017

The examples don't fail anymore with read_csv, so let's add them as tests.

Closes #2697.

@gfyoung gfyoung added IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite labels Nov 6, 2017
@gfyoung gfyoung added this to the 0.21.1 milestone Nov 6, 2017
@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #18136 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18136      +/-   ##
==========================================
- Coverage   91.28%   91.24%   -0.04%     
==========================================
  Files         163      163              
  Lines       50122    50122              
==========================================
- Hits        45752    45732      -20     
- Misses       4370     4390      +20
Flag Coverage Δ
#multiple 89.05% <ø> (-0.03%) ⬇️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/io/parsers.py 95.57% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1181622...ff98f38. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #18136 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18136      +/-   ##
==========================================
- Coverage   91.28%   91.24%   -0.04%     
==========================================
  Files         163      163              
  Lines       50122    50122              
==========================================
- Hits        45752    45732      -20     
- Misses       4370     4390      +20
Flag Coverage Δ
#multiple 89.05% <ø> (-0.03%) ⬇️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/io/parsers.py 95.57% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1181622...ff98f38. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Nov 6, 2017

@gfyoung worth adding the parse_dates=True as additional xfails here? (or maybe just open a new issue with that case)? maybe even show a warning that things are losing precision?

@gfyoung
Copy link
Member Author

gfyoung commented Nov 6, 2017

@jreback : I'm not sure I follow you here. The tests are parametrized so that they pass regardless of whether parse_dates=True or False! 😄

@jreback
Copy link
Contributor

jreback commented Nov 6, 2017

right but the original issues shows a loss of precision when parse_dates=True
is that fixed (original issue gives a symptom that doesn’t have an easy fix)or is it just the way it is?

@gfyoung
Copy link
Member Author

gfyoung commented Nov 6, 2017

Yes, the issue is fixed on master (somehow). That's why my test checks the output for parse_dates=True (with no xfail).

@jreback jreback merged commit e23bd24 into pandas-dev:master Nov 6, 2017
@jreback
Copy link
Contributor

jreback commented Nov 6, 2017

thanks @gfyoung if you figure out where then add a reference here (not a big deal though)

@gfyoung gfyoung deleted the parse-dates-fail-test branch November 7, 2017 03:38
watercrossing pushed a commit to watercrossing/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants