BUG: Don't parse NA-values in index when requested #18127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Bug
IO CSV
@jreback : I agree with this suggestion. I could also deprecate the parameter in this PR as well? |
Codecov Report
@@ Coverage Diff @@
## master #18127 +/- ##
==========================================
- Coverage 91.28% 91.26% -0.02%
==========================================
Files 163 163
Lines 50127 50130 +3
==========================================
- Hits 45757 45752 -5
- Misses 4370 4378 +8
Continue to review full report at Codecov.
|
jreback
reviewed
Nov 6, 2017
doc/source/whatsnew/v0.21.1.txt
Outdated
| @@ -79,6 +79,7 @@ I/O | |||
|
|
|||
| - Bug in class:`~pandas.io.stata.StataReader` not converting date/time columns with display formatting addressed (:issue:`17990`). Previously columns with display formatting were normally left as ordinal numbers and not converted to datetime objects. | |||
| - Bug in :func:`read_csv` when reading a compressed UTF-16 encoded file (:issue:`18071`) | |||
| - Bug in :func:`read_csv` when specifying null-value handling on index columns (:issue:`5239`) | |||
There was a problem hiding this comment.
maybe mention na_filter here
|
minor comment. merge when pushed and on green. |
gfyoung
force-pushed
the
index-na-filter
branch
from
c75ffb6 to
fdb6ef3
Compare
|
All is green, so merging. |
watercrossing
pushed a commit
to watercrossing/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
Closes pandas-devgh-5239. (cherry picked from commit c176a3c)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
na_filterparameter wasn't being respected when being applied on values in the index.Closes #5239.