Skip to content

cleanup unused imports, constants #18119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2017
Merged

cleanup unused imports, constants #18119

merged 5 commits into from
Nov 7, 2017

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Nov 5, 2017
@gfyoung
Copy link
Member

gfyoung commented Nov 5, 2017

@jbrockmendel : Minor flake8 error. Otherwise, should be good to go.

Also, I agree with you. Dependencies, what can I say? 😄

@jreback
Copy link
Contributor

jreback commented Nov 5, 2017

rebase

@codecov
Copy link

codecov bot commented Nov 5, 2017

Codecov Report

Merging #18119 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18119      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50124    50124              
==========================================
+ Hits        45742    45745       +3     
+ Misses       4382     4379       -3
Flag Coverage Δ
#multiple 89.07% <ø> (+0.02%) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/core/indexes/category.py 97.46% <0%> (ø) ⬆️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc69dc6...fe5ab80. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 5, 2017 •
edited
Loading

Codecov Report

Merging #18119 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18119      +/-   ##
==========================================
- Coverage   91.28%   91.23%   -0.05%     
==========================================
  Files         163      163              
  Lines       50122    50122              
==========================================
- Hits        45752    45731      -21     
- Misses       4370     4391      +21
Flag Coverage Δ
#multiple 89.05% <ø> (-0.03%) ⬇️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f17aa26...0611ad2. Read the comment docs.

jreback
jreback approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question

pandas/_libs/lib.pyx
import tslib
from tslib import NaT, Timestamp, Timedelta
import interval
from tslib import NaT, Timestamp, Timedelta, array_to_datetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont' really like this but i guess its how it is currently. this is a python level dep between lib and tslib.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timestamp and Timedelta aren't used in lib. A couple of modules use lib.Timestamp instead of tslib.Timestamp. The NaT dependency could be imported directly from tslibs.nattype. array_to_datetime... not really any good options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, just mentioning it

@jreback jreback added this to the 0.22.0 milestone Nov 6, 2017
@jreback jreback merged commit 537e880 into pandas-dev:master Nov 7, 2017
@jreback
Copy link
Contributor

jreback commented Nov 7, 2017

thanks!

@jbrockmendel jbrockmendel deleted the depsuck2 branch November 7, 2017 15:12
watercrossing pushed a commit to watercrossing/pandas that referenced this pull request Nov 10, 2017
@jbrockmendel @watercrossing
cleanup unused imports, constants (pandas-dev#18119)
6ffc57a
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jbrockmendel @No-Stream
cleanup unused imports, constants (pandas-dev#18119)
fd38d5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @gfyoung @jreback