-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BLD: Make sure to copy ZIP files for parser tests #18108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
good point. thanks @gfyoung |
Codecov Report
@@ Coverage Diff @@
## master #18108 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.02%
==========================================
Files 163 163
Lines 50123 50123
==========================================
- Hits 45741 45732 -9
- Misses 4382 4391 +9
Continue to review full report at Codecov.
|
(cherry-picked from commit a61bb6)
did you port to the 0.21.x branch? don't do that. we will move everything all at once in the order it was done. otherwise you can get conflicts. |
Oops, my bad. I thought that was what the backport label meant for us to do. Feel free to remove or revert (which ever is easiest). |
no, it means we should do it, but don't do it now. |
Yeah, that's what I meant. Should I just remove those two commits from the branch then? |
no its fine |
The ZIP file wasn't listed in
setup.py
from #18091.Will merge on green.