Skip to content

BLD: Make sure to copy ZIP files for parser tests #18108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 4, 2017

The ZIP file wasn't listed in setup.py from #18091.

Will merge on green.

@gfyoung gfyoung added the Build Library building on various platforms label Nov 4, 2017
@gfyoung gfyoung added this to the 0.21.1 milestone Nov 4, 2017
@jreback
Copy link
Contributor

jreback commented Nov 4, 2017

good point. thanks @gfyoung

@codecov
Copy link

codecov bot commented Nov 4, 2017

Codecov Report

Merging #18108 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18108      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50123    50123              
==========================================
- Hits        45741    45732       -9     
- Misses       4382     4391       +9
Flag Coverage Δ
#multiple 89.05% <ø> (ø) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3268f4e...a14fc58. Read the comment docs.

@gfyoung gfyoung merged commit a61bb64 into pandas-dev:master Nov 4, 2017
@gfyoung gfyoung deleted the parsers-zip-setup branch November 4, 2017 20:30
gfyoung added a commit that referenced this pull request Nov 4, 2017
@jreback
Copy link
Contributor

jreback commented Nov 4, 2017

did you port to the 0.21.x branch? don't do that. we will move everything all at once in the order it was done. otherwise you can get conflicts.

@gfyoung
Copy link
Member Author

gfyoung commented Nov 4, 2017

Oops, my bad. I thought that was what the backport label meant for us to do. Feel free to remove or revert (which ever is easiest).

@jreback
Copy link
Contributor

jreback commented Nov 4, 2017

no, it means we should do it, but don't do it now.

@gfyoung
Copy link
Member Author

gfyoung commented Nov 4, 2017

Yeah, that's what I meant. Should I just remove those two commits from the branch then?

@jreback
Copy link
Contributor

jreback commented Nov 4, 2017

no its fine

1kastner pushed a commit to 1kastner/pandas that referenced this pull request Nov 5, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants